lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Jun 2022 01:12:31 +0800 From: Zhi Song <zhi.song@...edance.com> To: Greg KH <gregkh@...uxfoundation.org> Cc: rafael@...nel.org, linux-kernel@...r.kernel.org Subject: Re: [External] [PATCH] node: put_device after failing to device_register > On Jun 14, 2022, at 22:37, Greg KH <gregkh@...uxfoundation.org> wrote: > > On Tue, Jun 14, 2022 at 10:30:07PM +0800, Zhi Song wrote: >> device_register() is used to register a device with the system. >> >> We cannot directly free dev after calling this function, >> even if it returns an error. > > the device is not being freed, why say this? > > And you do have a full 72 columns to use :) > >> >> We should use put_device() to give up the reference >> initialized in this function instead. > > There is no "instead" happening here. The patch looks correct, but this > changelog text does not. Please fix up. > > thanks, > > greg k-h Hi Greg, I have submitted this fixed patch here: https://lore.kernel.org/all/20220621171623.1959231-1-zhi.song@bytedance .com/ take a look if there's anything wrong. :) Thanks, Zhi
Powered by blists - more mailing lists