lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Jun 2022 18:08:09 +0000 From: "Kalra, Ashish" <Ashish.Kalra@....com> To: Jeremi Piotrowski <jpiotrowski@...ux.microsoft.com> CC: "x86@...nel.org" <x86@...nel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>, "linux-coco@...ts.linux.dev" <linux-coco@...ts.linux.dev>, "linux-mm@...ck.org" <linux-mm@...ck.org>, "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>, "tglx@...utronix.de" <tglx@...utronix.de>, "mingo@...hat.com" <mingo@...hat.com>, "jroedel@...e.de" <jroedel@...e.de>, "Lendacky, Thomas" <Thomas.Lendacky@....com>, "hpa@...or.com" <hpa@...or.com>, "ardb@...nel.org" <ardb@...nel.org>, "pbonzini@...hat.com" <pbonzini@...hat.com>, "seanjc@...gle.com" <seanjc@...gle.com>, "vkuznets@...hat.com" <vkuznets@...hat.com>, "jmattson@...gle.com" <jmattson@...gle.com>, "luto@...nel.org" <luto@...nel.org>, "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>, "slp@...hat.com" <slp@...hat.com>, "pgonda@...gle.com" <pgonda@...gle.com>, "peterz@...radead.org" <peterz@...radead.org>, "srinivas.pandruvada@...ux.intel.com" <srinivas.pandruvada@...ux.intel.com>, "rientjes@...gle.com" <rientjes@...gle.com>, "dovmurik@...ux.ibm.com" <dovmurik@...ux.ibm.com>, "tobin@....com" <tobin@....com>, "bp@...en8.de" <bp@...en8.de>, "Roth, Michael" <Michael.Roth@....com>, "vbabka@...e.cz" <vbabka@...e.cz>, "kirill@...temov.name" <kirill@...temov.name>, "ak@...ux.intel.com" <ak@...ux.intel.com>, "tony.luck@...el.com" <tony.luck@...el.com>, "marcorr@...gle.com" <marcorr@...gle.com>, "sathyanarayanan.kuppuswamy@...ux.intel.com" <sathyanarayanan.kuppuswamy@...ux.intel.com>, "alpergun@...gle.com" <alpergun@...gle.com>, "dgilbert@...hat.com" <dgilbert@...hat.com>, "jarkko@...nel.org" <jarkko@...nel.org> Subject: RE: [PATCH Part2 v6 10/49] x86/fault: Add support to dump RMP entry on fault [AMD Official Use Only - General] >> > +void dump_rmpentry(u64 pfn) >> > +{ >> > + unsigned long pfn_end; >> > + struct rmpentry *e; >> > + int level; >> > + >> > + e = __snp_lookup_rmpentry(pfn, &level); >> > + if (!e) { >> >> __snp_lookup_rmpentry may return -errno so this should be: >> >> if (e != 1) >Sorry, actually it should be: > if (IS_ERR_OR_NULL(e)) { I will fix this accordingly. >> > + >> > + while (pfn < pfn_end) { >> > + e = __snp_lookup_rmpentry(pfn, &level); >> > + if (!e) >> >> if (e != 1) >> >and this too: > if (IS_ERR_OR_NULL(e)) Same here. Thanks, Ashish
Powered by blists - more mailing lists