linux-kernel - Re: [PATCH] block: drbd: drbd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Jun 2022 22:57:32 +0200
From:   Christoph Böhmwalder 
        <christoph.boehmwalder@...bit.com>
To:     Jiang Jian <jiangjian@...rlc.com>
Cc:     philipp.reisner@...bit.com, lars.ellenberg@...bit.com,
        drbd-dev@...ts.linbit.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, axboe@...nel.dk
Subject: Re: [PATCH] block: drbd: drbd_state: Fix typo in comments

Am 22.06.22 um 17:52 schrieb Jiang Jian:
> Replace 'is' with 'it'
> 
> file: drivers/block/drbd/drbd_state.c
> line: 1900
> 
> * But is is still not save to dreference ldev here, since
> 
> changed to:
> 
> * But it is still not save to dreference ldev here, since
> 
> Signed-off-by: Jiang Jian <jiangjian@...rlc.com>
> ---
>  drivers/block/drbd/drbd_state.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/drbd/drbd_state.c b/drivers/block/drbd/drbd_state.c
> index 3f7bf9f2d874..99927c44f0c3 100644
> --- a/drivers/block/drbd/drbd_state.c
> +++ b/drivers/block/drbd/drbd_state.c
> @@ -1897,7 +1897,7 @@ static void after_state_ch(struct drbd_device *device, union drbd_state os,
>  		int was_io_error = 0;
>  		/* corresponding get_ldev was in _drbd_set_state, to serialize
>  		 * our cleanup here with the transition to D_DISKLESS.
> -		 * But is is still not save to dreference ldev here, since
> +		 * But it is still not save to dreference ldev here, since
>  		 * we might come from an failed Attach before ldev was set. */
>  		if (device->ldev) {
>  			rcu_read_lock();

I agree with James here, I do not think this provides much value.

In fact, the *same* line you are changing contains two more spelling
mistakes ("save" and "dreference").

My opinion is that trivial patches like this are fine as a starting
point for new contributors, which is why I acked the previous patch from
you guys. However, if we start getting two of these every week it just
adds more maintenance burden than it's worth.

So thanks for the contribution, but it's a NAK from me.

-- 
Christoph Böhmwalder
LINBIT | Keeping the Digital World Running
DRBD HA —  Disaster Recovery — Software defined Storage