| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <DU0PR04MB94175AB468DA032384FC6D1188B29@DU0PR04MB9417.eurprd04.prod.outlook.com>
Date: Wed, 22 Jun 2022 22:33:59 +0000
From: Peng Fan <peng.fan@....com>
To: Saravana Kannan <saravanak@...gle.com>,
Sascha Hauer <s.hauer@...gutronix.de>
CC: "Peng Fan (OSS)" <peng.fan@....nxp.com>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>,
"shawnguo@...nel.org" <shawnguo@...nel.org>,
"festevam@...il.com" <festevam@...il.com>,
dl-linux-imx <linux-imx@....com>,
"hvilleneuve@...onoff.com" <hvilleneuve@...onoff.com>,
"l.stach@...gutronix.de" <l.stach@...gutronix.de>,
"abbaraju.manojsai@...rulasolutions.com"
<abbaraju.manojsai@...rulasolutions.com>,
"jagan@...rulasolutions.com" <jagan@...rulasolutions.com>,
"matteo.lisi@...icam.com" <matteo.lisi@...icam.com>,
"tharvey@...eworks.com" <tharvey@...eworks.com>,
"t.remmet@...tec.de" <T.remmet@...tec.de>,
"u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
"t.remmet@...tec.deh" <t.remmet@...tec.deh>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] arm64: dts: imx8mp: drop dmas property for uart console
> Subject: Re: [PATCH] arm64: dts: imx8mp: drop dmas property for uart console
>
> On Wed, Jun 22, 2022 at 12:24 AM Sascha Hauer <s.hauer@...gutronix.de>
> wrote:
> >
> > +Cc Saravana Kannan <saravanak@...gle.com>, the author of
> > +71066545b48e4
> >
> > On Wed, Jun 22, 2022 at 02:20:27PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@....com>
> > >
> > > Commit 71066545b48e4("driver core: Set fw_devlink.strict=1 by
> > > default") default set fw_devlink to true. This has a side effect to
> > > i.MX uart console. The sdma will make the i.MX8MP uart driver defer
> > > probe for some time (~10s with i.MX8MP-EVK board) until sdma ready,
> > > because sdma is a supplier with property dmas set in device tree node.
> >
> > I just tested this on an i.MX6 board and observed the same behaviour.
> > The same will happen on any other i.MX board as well. This will also
> > likely happen on any other SoC on which the UART driver uses dmaengine.
> >
> > >
> > > Since this uart is for console, we need log printed out as soon as
> > > possible, so remove the dmas property for the uart console node.
> >
> > Fixing this at board level is not really an option because that means
> > fixing each and every, at least i.MX board in the tree. Furthermore
> > this would mean to bring the deleted property back in and to remove
> > another dmas property should a user want to switch to another console
> > port.
> >
> > For what it's worth: NACK for 71066545b48e4.
>
> Peng, I sent a fix. Can you give it a shot please?
Thanks for the quick fix. I have replied your patch with my T-b.
My patch could be dropped.
Thanks,
Peng.
>
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.ke
> rnel.org%2Flkml%2F20220622215912.550419-1-saravanak%40google.com%
> 2F&data=05%7C01%7Cpeng.fan%40nxp.com%7C7a841838946c4df32eb
> 408da549efa47%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
> 7915339019509985%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMD
> AiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C
> &sdata=wO7NEebGVRp1C7LvhRyZnTTzJwma5eHDfDcoAqdLE24%3D&am
> p;reserved=0
>
> -Saravana
>
> >
> > Sascha
> >
> > >
> > > Signed-off-by: Peng Fan <peng.fan@....com>
> > > ---
> > >
> > > V1:
> > > The upper set fw_devlink.strict=1 patch is in linux-next tree.
> > >
> > > arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 2
> ++
> > > arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dts | 2
> > > ++ arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts |
> 2 ++
> > > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 2
> ++
> > > 4 files changed, 8 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> > > b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> > > index fb11c03bc8b1..3fdb38bc0069 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> > > @@ -359,6 +359,8 @@ &uart2 {
> > > pinctrl-names = "default";
> > > pinctrl-0 = <&pinctrl_uart2>;
> > > status = "okay";
> > > + /delete-property/ dmas;
> > > + /delete-property/ dma-names;
> > > };
> > >
> > > &usb3_phy1 {
> > > diff --git
> > > a/arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dts
> > > b/arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dts
> > > index dd703b6a5e17..fb2b44e94482 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dts
> > > +++
> b/arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dts
> > > @@ -69,6 +69,8 @@ &uart2 {
> > > pinctrl-names = "default";
> > > pinctrl-0 = <&pinctrl_uart2>;
> > > status = "okay";
> > > + /delete-property/ dmas;
> > > + /delete-property/ dma-names;
> > > };
> > >
> > > &usb3_phy0 {
> > > diff --git
> > > a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
> > > b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
> > > index 6aa720bafe28..68a478151292 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
> > > @@ -99,6 +99,8 @@ &uart1 {
> > > pinctrl-names = "default";
> > > pinctrl-0 = <&pinctrl_uart1>;
> > > status = "okay";
> > > + /delete-property/ dmas;
> > > + /delete-property/ dma-names;
> > > };
> > >
> > > /* SD-Card */
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > > b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > > index 521215520a0f..f90c1ac2791c 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > > @@ -554,6 +554,8 @@ &uart2 {
> > > pinctrl-names = "default";
> > > pinctrl-0 = <&pinctrl_uart2>;
> > > status = "okay";
> > > + /delete-property/ dmas;
> > > + /delete-property/ dma-names;
> > > };
> > >
> > > &uart4 {
> > > --
> > > 2.25.1
> > >
> > >
> >
> > --
> > Pengutronix e.K. |
> |
> > Steuerwalder Str. 21 |
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pe
> ngutronix.de%2F&data=05%7C01%7Cpeng.fan%40nxp.com%7C7a84183
> 8946c4df32eb408da549efa47%7C686ea1d3bc2b4c6fa92cd99c5c301635%7
> C0%7C0%7C637915339019509985%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi
> MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300
> 0%7C%7C%7C&sdata=h0WK5980JKlkNVax%2F7PopVftgkClnG0SLAvuPqh
> lj0A%3D&reserved=0 |
> > 31137 Hildesheim, Germany | Phone:
> +49-5121-206917-0 |
> > Amtsgericht Hildesheim, HRA 2686 | Fax:
> +49-5121-206917-5555 |
Powered by blists - more mailing lists