linux-kernel - Re: [PATCH v3] xfs: add check before calling xfs_mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANubcdXyM2t0M0Ks3=6Hm12_SVm50vGaTBboj5CBF2LygOkUog@mail.gmail.com>
Date:   Wed, 22 Jun 2022 13:57:31 +0800
From:   Stephen Zhang <starzhangzsd@...il.com>
To:     "Darrick J. Wong" <djwong@...nel.org>
Cc:     dchinner@...hat.com, zhangshida <zhangshida@...inos.cn>,
        linux-kernel@...r.kernel.org, linux-xfs@...r.kernel.org
Subject: Re: [PATCH v3] xfs: add check before calling xfs_mod_fdblocks

> I understand that calling __xfs_ag_resv_init on an AG with a maximally
> sized data structure can result in @hidden_space being zero here, but
> why does that matter enough to change the code?  Are you experiencing
> problems when this happens?  Unnecessary slowdowns at mount time?
> Something else?
>
> This is v3 of a patch and I still can't tell why I should care ...?

After applying this patch, we can avoid to call xfs_mod_fdblocks when
delta equals 0. So we can reduce unnecessary operations here.