[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220622065117.23210-1-hbh25y@gmail.com>
Date: Wed, 22 Jun 2022 14:51:17 +0800
From: Hangyu Hua <hbh25y@...il.com>
To: krzysztof.kozlowski@...aro.org, sameo@...ux.intel.com,
christophe.ricard@...il.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
Hangyu Hua <hbh25y@...il.com>
Subject: [PATCH] nfc: st21nfca: fix possible double free in st21nfca_im_recv_dep_res_cb()
nfc_tm_data_received will free skb internally when it fails. There is no
need to free skb in st21nfca_im_recv_dep_res_cb again.
Fix this by setting skb to NULL when nfc_tm_data_received fails.
Fixes: 1892bf844ea0 ("NFC: st21nfca: Adding P2P support to st21nfca in Initiator & Target mode")
Signed-off-by: Hangyu Hua <hbh25y@...il.com>
---
drivers/nfc/st21nfca/dep.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nfc/st21nfca/dep.c b/drivers/nfc/st21nfca/dep.c
index 1ec651e31064..07ac5688011c 100644
--- a/drivers/nfc/st21nfca/dep.c
+++ b/drivers/nfc/st21nfca/dep.c
@@ -594,7 +594,8 @@ static void st21nfca_im_recv_dep_res_cb(void *context, struct sk_buff *skb,
ST21NFCA_NFC_DEP_PFB_PNI(dep_res->pfb + 1);
size++;
skb_pull(skb, size);
- nfc_tm_data_received(info->hdev->ndev, skb);
+ if (nfc_tm_data_received(info->hdev->ndev, skb))
+ skb = NULL;
break;
case ST21NFCA_NFC_DEP_PFB_SUPERVISOR_PDU:
pr_err("Received a SUPERVISOR PDU\n");
--
2.25.1
Powered by blists - more mailing lists