linux-kernel - Re: [PATCH v7 07/14] ALSA: hda: cs35l41: Support multiple load paths for firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <298dd904-586a-d09f-2e14-0e0fc45385fa@linux.intel.com>
Date:   Wed, 22 Jun 2022 10:40:38 +0200
From:   Amadeusz Sławiński 
        <amadeuszx.slawinski@...ux.intel.com>
To:     Vitaly Rodionov <vitalyr@...nsource.cirrus.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, Mark Brown <broonie@...nel.org>
Cc:     patches@...nsource.cirrus.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org,
        Stefan Binding <sbinding@...nsource.cirrus.com>
Subject: Re: [PATCH v7 07/14] ALSA: hda: cs35l41: Support multiple load paths
 for firmware

On 6/22/2022 9:46 AM, Vitaly Rodionov wrote:
> From: Stefan Binding <sbinding@...nsource.cirrus.com>
> 
> To be able to support different firmwares and tuning
> for different models, the driver needs to be able to
> load a different firmware and coefficient file based
> on its Subsystem ID.
> 
> The driver attempts to load the firmware in the
> following order:
> 
> /lib/firmware/cirrus/cs35l41-dsp1-<fw-type>-<ssid>-dev<#>.wmfw
> /lib/firmware/cirrus/cs35l41-dsp1-<fw-type>-<ssid>.wmfw
> /lib/firmware/cirrus/cs35l41-dsp1-<fw-type>.wmfw
> 
> Signed-off-by: Stefan Binding <sbinding@...nsource.cirrus.com>
> Signed-off-by: Vitaly Rodionov <vitalyr@...nsource.cirrus.com>
> ---

...

	    CS35L41_FIRMWARE_ROOT, NULL, NULL, "wmfw");
> +	if (!ret) {
> +		/* fallback try cirrus/part-dspN-fwtype.bin */
>   		cs35l41_request_firmware_file(cs35l41, coeff_firmware, coeff_filename,
> -					      CS35L41_FIRMWARE_ROOT, "bin");
> +					      CS35L41_FIRMWARE_ROOT, NULL, NULL, "bin");
>   		return 0;
>   	}
>   
> @@ -143,7 +183,6 @@ static int cs35l41_request_firmware_files(struct cs35l41_hda *cs35l41,
>   	return ret;
>   }
>   
> -

You add unnecessary line in patch 4 and remove in this one?

>   static int cs35l41_init_dsp(struct cs35l41_hda *cs35l41)
>   {
>   	const struct firmware *coeff_firmware = NULL;