[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c0bd4b10-f846-6a6e-06a4-57284f536a98@linux.intel.com>
Date: Wed, 22 Jun 2022 10:40:29 +0200
From: Amadeusz Sławiński
<amadeuszx.slawinski@...ux.intel.com>
To: Vitaly Rodionov <vitalyr@...nsource.cirrus.com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, Mark Brown <broonie@...nel.org>
Cc: patches@...nsource.cirrus.com, alsa-devel@...a-project.org,
linux-kernel@...r.kernel.org,
Stefan Binding <sbinding@...nsource.cirrus.com>
Subject: Re: [PATCH v7 05/14] ALSA: hda: cs35l41: Save Subsystem ID inside
CS35L41 Driver
On 6/22/2022 9:46 AM, Vitaly Rodionov wrote:
> From: Stefan Binding <sbinding@...nsource.cirrus.com>
>
> The Subsystem ID is read from the HDA driver, and will
> be used by the CS35L41 driver to be able to uniquely
> identify the laptop, which is required to be able to
> define firmware to be used by specific models.
>
> Signed-off-by: Stefan Binding <sbinding@...nsource.cirrus.com>
> Signed-off-by: Vitaly Rodionov <vitalyr@...nsource.cirrus.com>
> ---
> sound/pci/hda/cs35l41_hda.c | 3 +++
> sound/pci/hda/cs35l41_hda.h | 1 +
> sound/pci/hda/hda_component.h | 1 +
> sound/pci/hda/patch_realtek.c | 1 +
> 4 files changed, 6 insertions(+)
>
> diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
> index 92c6d8b7052e..7f0132694774 100644
> --- a/sound/pci/hda/cs35l41_hda.c
> +++ b/sound/pci/hda/cs35l41_hda.c
> @@ -356,6 +356,9 @@ static int cs35l41_hda_bind(struct device *dev, struct device *master, void *mas
> return -EBUSY;
>
> comps->dev = dev;
> + if (!cs35l41->acpi_subsystem_id)
> + cs35l41->acpi_subsystem_id = devm_kasprintf(dev, GFP_KERNEL,
> + "%.8x", comps->subsystem_id);
Wouldn't comps->codec->core.subsystem_id instead of comps->subsystem_id
work here? You already added saving of codec in patch 3, and then you
don't need rest of this patch?
Powered by blists - more mailing lists