linux-kernel - Re: [PATCH v2 1/6] dt-bindings: arm: qcom: Document additional sc8280xp devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YrLXCx90bn7Id4Bn@hovoldconsulting.com>
Date:   Wed, 22 Jun 2022 10:47:07 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Andy Gross <agross@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Jassi Brar <jassisinghbrar@...il.com>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: arm: qcom: Document additional
 sc8280xp devices

On Tue, Jun 21, 2022 at 09:12:19PM -0700, Bjorn Andersson wrote:
> Add the CRD (Customer Reference Design?) and the Lenovo Thinkpad X13s to

Qualcomm refers to "Compute Reference Design", for example, in commit
427b249504ea ("arm64: dts: qcom: sc7280-crd: Add device tree files for
CRD").

> the valid device compatibles found on the sc8280xp platform.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> ---
> 
> Changes since v1:
> - Added the two missing board compatibles
> 
>  Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 5c06d1bfc046..6ec7521be19d 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -238,6 +238,8 @@ properties:
>  
>        - items:
>            - enum:
> +              - lenovo,thinkpad-x13s
> +              - qcom,sc8280xp-crd
>                - qcom,sc8280xp-qrd

I believe the "qcom,sc8280xp-qrd" entry was a mistake and should have
been "-crd" all along? Perhaps you should remove that entry in this
patch.

>            - const: qcom,sc8280xp

Looks good otherwise:

Reviewed-by: Johan Hovold <johan+linaro@...nel.org>

Johan