lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.22.394.2206220513590.2646@hadrien>
Date:   Wed, 22 Jun 2022 05:16:21 -0400 (EDT)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Shahab Vahedi <Shahab.Vahedi@...opsys.com>
cc:     Bagas Sanjaya <bagasdotme@...il.com>,
        Jilin Yuan <yuanjilin@...rlc.com>,
        "vgupta@...nel.org" <vgupta@...nel.org>,
        "Julia.Lawall@...ia.fr" <Julia.Lawall@...ia.fr>,
        "rdunlap@...radead.org" <rdunlap@...radead.org>,
        "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARC:mm:Fix syntax errors in comments



On Wed, 22 Jun 2022, Shahab Vahedi wrote:

> On 6/22/22 10:30, Bagas Sanjaya wrote:
>
> > I think that this kind of cleanup patches (typofixes) are best done
> > as part of **actual** work on the code in question (for example
> > refactoring or fixing build errors).
>
> Amen!

So code that is fine will have typos forever?  Fixing typos in comments
doesn't break git blame for the following code.  And typos in comments
give a bad impression about the state of the code in general.

But that is a general statement.  Perhaps this code does particularly need
work.

julia

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ