linux-kernel - Re: [PATCH] alpha: irq_i8259: drop unexpected word 'and' in the comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Jun 2022 14:08:14 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <jiangjian@...rlc.com>, <rth@...ddle.net>,
        <ink@...assic.park.msu.ru>, <mattst88@...il.com>
CC:     <linux-alpha@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] alpha: irq_i8259: drop unexpected word 'and' in the
 comments


On 22/06/2022 15:02, Jiang Jian wrote:
> there is an unexpected word 'and' in the comments that need to be dropped
> 
> file: arch/alpha/kernel/irq_i8259.c
> line: 150
> 
> *  Therefore, read the mask register and and out those lines
> 
> changed to:
> 
> *  Therefore, read the mask register and and out those lines
> 
> Signed-off-by: Jiang Jian <jiangjian@...rlc.com>
> ---
>   arch/alpha/kernel/irq_i8259.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/alpha/kernel/irq_i8259.c b/arch/alpha/kernel/irq_i8259.c
> index 1dcf0d9038fd..db574dcd6675 100644
> --- a/arch/alpha/kernel/irq_i8259.c
> +++ b/arch/alpha/kernel/irq_i8259.c
> @@ -147,7 +147,7 @@ isa_no_iack_sc_device_interrupt(unsigned long vector)
>   	 */
>   	/*
>   	 *  The first read of gives you *all* interrupting lines.
> -	 *  Therefore, read the mask register and and out those lines
> +	 *  Therefore, read the mask register and out those lines

This does not look like a typo? Surely the second and means the
operator? Maybe it could be reworded for more clarity to something
like "and mask out", but the initial meaning looks sane

Thanks,
Conor.

>   	 *  not enabled.  Note that some documentation has 21 and a1
>   	 *  write only.  This is not true.
>   	 */