linux-kernel - Re: [PATCH v2 02/13] dt-bindings: Add headers for Host1x and VIC on Tegra234

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6a8e40d-ca4d-a688-988d-6800150d4e68@linaro.org>
Date:   Wed, 22 Jun 2022 16:23:53 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Mikko Perttunen <cyndis@...si.fi>, thierry.reding@...il.com,
        jonathanh@...dia.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, digetx@...il.com
Cc:     dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mikko Perttunen <mperttunen@...dia.com>
Subject: Re: [PATCH v2 02/13] dt-bindings: Add headers for Host1x and VIC on
 Tegra234

On 22/06/2022 13:37, Mikko Perttunen wrote:
> From: Mikko Perttunen <mperttunen@...dia.com>
> 
> Add clock, memory controller, powergate and reset dt-binding headers
> for Host1x and VIC on Tegra234.
> 
> Signed-off-by: Mikko Perttunen <mperttunen@...dia.com>
> ---
>  include/dt-bindings/clock/tegra234-clock.h     | 4 ++++
>  include/dt-bindings/memory/tegra234-mc.h       | 5 +++++
>  include/dt-bindings/power/tegra234-powergate.h | 1 +
>  include/dt-bindings/reset/tegra234-reset.h     | 1 +
>  4 files changed, 11 insertions(+)
> 

It's not the fault of this patch but in the past you started encoding
some register offsets or values in the bindings. That's not what
bindings headers are for. Store here hardware-independent IDs or
nothing. For new Tegra SoCs I might start pushing this back...

Anyway, it's not this patch which introduced it, so:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>


Best regards,
Krzysztof