| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <39f3d46f7731617cb84e6c9f16698e369aa5fd77.1655906573.git.pengfei.xu@intel.com>
Date: Wed, 22 Jun 2022 22:33:13 +0800
From: Pengfei Xu <pengfei.xu@...el.com>
To: Shuah Khan <skhan@...uxfoundation.org>,
linux-kselftest <linux-kselftest@...r.kernel.org>,
linux-kernel <linux-kernel@...r.kernel.org>
Cc: Pengfei Xu <pengfei.xu@...el.com>, Heng Su <heng.su@...el.com>,
Hansen Dave <dave.hansen@...el.com>,
Luck Tony <tony.luck@...el.com>,
Mehta Sohil <sohil.mehta@...el.com>,
Chen Yu C <yu.c.chen@...el.com>,
Andy Lutomirski <luto@...nel.org>,
Borislav Petkov <bp@...e.de>,
Thomas Gleixner <tglx@...utronix.de>,
Bae Chang Seok <chang.seok.bae@...el.com>
Subject: [PATCH v10 2/2] selftests/x86/xstate: Add xstate fork test for XSAVE feature
In order to ensure that XSAVE works correctly, add XSAVE most basic fork
test:
1. The contents of these xstates in the child process should be the same as
the contents of the xstate in the parent process after the fork syscall.
2. The contents of xstates in the parent process should not change after
the context switch.
[ Dave Hansen; Chang S. Bae; Shuah Khan: bunches of cleanups ]
Reviewed-by: Chang S. Bae <chang.seok.bae@...el.com>
Signed-off-by: Pengfei Xu <pengfei.xu@...el.com>
---
tools/testing/selftests/x86/xstate.c | 22 ++++++-
tools/testing/selftests/x86/xstate.h | 1 +
tools/testing/selftests/x86/xstate_helpers.c | 67 ++++++++++++++++++++
tools/testing/selftests/x86/xstate_helpers.h | 2 +
4 files changed, 91 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/x86/xstate.c b/tools/testing/selftests/x86/xstate.c
index 4eff539e783d..4abb46fe40dc 100644
--- a/tools/testing/selftests/x86/xstate.c
+++ b/tools/testing/selftests/x86/xstate.c
@@ -39,7 +39,7 @@
#include "xstate_helpers.h"
#include "../kselftest.h"
-#define NUM_TESTS 1
+#define NUM_TESTS 3
#define xstate_test_array_init(idx, init_opt, fill_opt) \
do { \
xstate_tests[idx].init = init_opt; \
@@ -106,6 +106,25 @@ static void test_xstate_sig_handle(void)
compare_buf_result(valid_xbuf, compared_xbuf, case_name1);
}
+static void test_xstate_fork(void)
+{
+ const char *case_name2 = "xstate of child process should be same as xstate of parent";
+ const char *case_name3 = "parent xstate should be same after context switch";
+
+ ksft_print_msg("[RUN]\tParent pid:%d check xstate around fork test.\n",
+ getpid());
+ /* Child process xstate should be same as the parent process xstate. */
+ if (xstate_fork(valid_xbuf, compared_xbuf, xstate_info.mask,
+ xstate_size)) {
+ ksft_test_result_pass("The case: %s.\n", case_name2);
+ } else {
+ ksft_test_result_fail("The case: %s.\n", case_name2);
+ }
+
+ /* The parent process xstate should not change after context switch. */
+ compare_buf_result(valid_xbuf, compared_xbuf, case_name3);
+}
+
static void prepare_xstate_test(void)
{
xstate_test_array_init(XFEATURE_FP, init_legacy_info,
@@ -124,6 +143,7 @@ static void prepare_xstate_test(void)
fill_pkru_xstate_buf);
xstate_tests[XSTATE_CASE_SIG].xstate_case = test_xstate_sig_handle;
+ xstate_tests[XSTATE_CASE_FORK].xstate_case = test_xstate_fork;
}
static void test_xstate(void)
diff --git a/tools/testing/selftests/x86/xstate.h b/tools/testing/selftests/x86/xstate.h
index 92c853d64e99..c9ec4cbf141e 100644
--- a/tools/testing/selftests/x86/xstate.h
+++ b/tools/testing/selftests/x86/xstate.h
@@ -82,6 +82,7 @@ enum xfeature {
enum xstate_case {
XSTATE_CASE_SIG,
+ XSTATE_CASE_FORK,
XSTATE_CASE_MAX,
};
diff --git a/tools/testing/selftests/x86/xstate_helpers.c b/tools/testing/selftests/x86/xstate_helpers.c
index 93838c95aaea..e06b07a662b5 100644
--- a/tools/testing/selftests/x86/xstate_helpers.c
+++ b/tools/testing/selftests/x86/xstate_helpers.c
@@ -73,6 +73,22 @@ inline void fill_fp_mxcsr_xstate_buf(void *buf, int xfeature_num,
__xsave(buf, MASK_FP_SSE);
}
+/*
+ * Because xstate like XMM, YMM registers are not preserved across function
+ * calls, so use inline function with assembly code only for fork syscall.
+ */
+static inline long __fork(void)
+{
+ long ret, nr = SYS_fork;
+
+ asm volatile("syscall"
+ : "=a" (ret)
+ : "a" (nr), "b" (nr)
+ : "rcx", "r11", "memory", "cc");
+
+ return ret;
+}
+
/*
* Because xstate like XMM, YMM registers are not preserved across function
* calls, so use inline function with assembly code only to raise signal.
@@ -140,3 +156,54 @@ bool xstate_sig_handle(void *valid_xbuf, void *compared_xbuf, uint64_t mask,
return sigusr1_done;
}
+
+bool xstate_fork(void *valid_xbuf, void *compared_xbuf, uint64_t mask,
+ uint32_t xstate_size)
+{
+ pid_t child;
+ int status, fd[2];
+ bool child_result;
+
+ memset(compared_xbuf, 0, xstate_size);
+ /* Use pipe to transfer test result to parent process. */
+ if (pipe(fd) < 0)
+ fatal_error("create pipe failed");
+ /*
+ * Xrstor the valid_xbuf and call syscall assembly instruction, then
+ * save the xstate to compared_xbuf in child process for comparison.
+ */
+ __xrstor(valid_xbuf, mask);
+ child = __fork();
+ if (child < 0) {
+ /* Fork syscall failed */
+ fatal_error("fork failed");
+ } else if (child == 0) {
+ /* Fork syscall succeeded, now in the child. */
+ __xsave(compared_xbuf, mask);
+
+ if (memcmp(valid_xbuf, compared_xbuf, xstate_size))
+ child_result = false;
+ else
+ child_result = true;
+
+ /*
+ * Transfer the child process test result to
+ * the parent process for aggregation.
+ */
+ close(fd[0]);
+ if (!write(fd[1], &child_result, sizeof(child_result)))
+ fatal_error("write fd failed");
+ _exit(0);
+ } else {
+ /* Fork syscall succeeded, now in the parent. */
+ __xsave(compared_xbuf, mask);
+ if (waitpid(child, &status, 0) != child || !WIFEXITED(status)) {
+ fatal_error("Child exit with error status");
+ } else {
+ close(fd[1]);
+ if (!read(fd[0], &child_result, sizeof(child_result)))
+ fatal_error("read fd failed");
+ return child_result;
+ }
+ }
+}
diff --git a/tools/testing/selftests/x86/xstate_helpers.h b/tools/testing/selftests/x86/xstate_helpers.h
index 1806c0bf484b..307781708ffa 100644
--- a/tools/testing/selftests/x86/xstate_helpers.h
+++ b/tools/testing/selftests/x86/xstate_helpers.h
@@ -6,3 +6,5 @@ extern void fill_fp_mxcsr_xstate_buf(void *buf, int xfeature_num,
uint8_t ui8_fp);
extern bool xstate_sig_handle(void *valid_xbuf, void *compared_xbuf,
uint64_t mask, uint32_t xstate_size);
+extern bool xstate_fork(void *valid_xbuf, void *compared_xbuf,
+ uint64_t mask, uint32_t xstate_size);
--
2.31.1
Powered by blists - more mailing lists