linux-kernel - Re: [PATCH] staging: r8188eu: Make rtw_signal_stat_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be6cc1a5-3eab-d0d0-fd93-68afeed7d7a1@gmail.com>
Date:   Thu, 23 Jun 2022 06:21:21 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Chang Yu <marcus.yu.56@...il.com>, Larry.Finger@...inger.net
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Make rtw_signal_stat_timer_hdl a static
 function

On 6/23/22 04:24, Chang Yu wrote:
> Make rtw_signal_stat_timer_hdl a static function instead of a global
> function.
> 
> Signed-off-by: Chang Yu <marcus.yu.56@...il.com>
> ---
>   drivers/staging/r8188eu/core/rtw_recv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c
> index cc91638a085d..599d3e55be76 100644
> --- a/drivers/staging/r8188eu/core/rtw_recv.c
> +++ b/drivers/staging/r8188eu/core/rtw_recv.c
> @@ -24,7 +24,7 @@ static u8 rtw_rfc1042_header[] = {
>   	0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
>   };
>   
> -void rtw_signal_stat_timer_hdl(struct timer_list *t);
> +static void rtw_signal_stat_timer_hdl(struct timer_list *t);
>   
>   void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv)
>   {

Hi,

thanks for your patch. I think you need the "static" for the declaration 
and the definition of the function. So it is missing in line 1789.

Thanks for your support.

Bye Philipp