linux-kernel - Re: [PATCH 0/2] arm64: fix lockdep in NMI context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165599516275.2981885.2147188564179543777.b4-ty@kernel.org>
Date:   Thu, 23 Jun 2022 20:31:41 +0100
From:   Will Deacon <will@...nel.org>
To:     Mark Rutland <mark.rutland@....com>,
        linux-arm-kernel@...ts.infradead.org
Cc:     catalin.marinas@....com, kernel-team@...roid.com,
        Will Deacon <will@...nel.org>, tglx@...utronix.de,
        peterz@...radead.org, mingo@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] arm64: fix lockdep in NMI context

On Wed, 11 May 2022 14:17:31 +0100, Mark Rutland wrote:
> For lockdep to function correctly in NMI context, architectures need to
> correctly save/restore lockdep state at NMI entry/exit time, correctly
> manage lockdep state within the NMI context, and need to select
> TRACE_IRQFLAGS_NMI_SUPPORT.
> 
> Currently arm64 falls short of this merely by failing to select
> TRACE_IRQFLAGS_NMI_SUPPORT, and this can result in spurious lockdep
> splats with GICv3 Pseudo-NMIs are in use. Patch 2 has an example.
> 
> [...]

This looks good to me and the x86 changes are trivial (famous last
words...), so I've queued the series up on its own branch in the arm64
tree.

Applied to arm64 (for-next/irqflags-nmi), thanks!

[1/2] arch: make TRACE_IRQFLAGS_NMI_SUPPORT generic
      https://git.kernel.org/arm64/c/4510bffb4d02
[2/2] arm64: select TRACE_IRQFLAGS_NMI_SUPPORT
      https://git.kernel.org/arm64/c/3381da254fab

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev