linux-kernel - Re: [RFC PATCH 1/3] mm/memory-tiers Add functions for tier memory usage in a cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bacbf819cc7a8ad6c1ca2a668c412ec8ee2c6edc.camel@linux.intel.com>
Date:   Thu, 23 Jun 2022 16:07:21 -0700
From:   Tim Chen <tim.c.chen@...ux.intel.com>
To:     "Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>,
        linux-mm@...ck.org, akpm@...ux-foundation.org
Cc:     Wei Xu <weixugc@...gle.com>, Huang Ying <ying.huang@...el.com>,
        Greg Thelen <gthelen@...gle.com>,
        Yang Shi <shy828301@...il.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        Brice Goglin <brice.goglin@...il.com>,
        Michal Hocko <mhocko@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Hesham Almatary <hesham.almatary@...wei.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Alistair Popple <apopple@...dia.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Feng Tang <feng.tang@...el.com>,
        Jagdish Gediya <jvgediya@...ux.ibm.com>,
        Baolin Wang <baolin.wang@...ux.alibaba.com>,
        David Rientjes <rientjes@...gle.com>,
        Shakeel Butt <shakeelb@...gle.com>
Subject: Re: [RFC PATCH 1/3] mm/memory-tiers Add functions for tier memory
 usage in a cgroup

On Tue, 2022-06-21 at 09:48 +0530, Aneesh Kumar K.V wrote:
> Tim Chen <tim.c.chen@...ux.intel.com> writes:
> 
>  +unsigned long mem_cgroup_toptier_usage(struct mem_cgroup *memcg)
> > +{
> > +	struct memory_tier *top_tier;
> > +
> > +	top_tier = list_first_entry(&memory_tiers, struct memory_tier, list);
> > +	if (top_tier)
> > +		return mem_cgroup_memtier_usage(memcg, top_tier);
> > +	else
> > +		return 0;
> > +}
> 
> As discussed here, we would want to consider all memory tiers that got
> compute as top tier.
> 
> https://lore.kernel.org/linux-mm/11f94e0c50f17f4a6a2f974cb69a1ae72853e2be.camel@intel.com
> 
> V6 patchset actually walk the full memory tier hierarchy reverse and consider any
> memory tier with higher or equal rank value than the first memory tier with CPU as top tier.
> 
> https://lore.kernel.org/linux-mm/20220610135229.182859-12-aneesh.kumar@linux.ibm.com
> 

Thanks.  Will take that into consideration for future patches.

Tim