linux-kernel - Re: [PATCH v9 0/6] Raspberry Pi Sense HAT driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <189021ff-c8d9-15d9-c997-c3e52eb01c38@i2se.com>
Date:   Thu, 23 Jun 2022 07:48:01 +0200
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Charles Mirabile <cmirabil@...hat.com>,
        linux-kernel@...r.kernel.org
Cc:     Serge Schneider <serge@...pberrypi.org>,
        Nicolas Saenz Julienne <nsaenzju@...hat.com>,
        Mattias Brugger <mbrugger@...e.com>,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, fedora-rpi@...glegroups.com,
        Daniel Bauman <dbauman@...hat.com>,
        Mwesigwa Guma <mguma@...hat.com>,
        Joel Savitz <jsavitz@...hat.com>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH v9 0/6] Raspberry Pi Sense HAT driver

Hi Charles,

Am 19.04.22 um 22:51 schrieb Charles Mirabile:
> This patch series adds a set of drivers for operating the Sense HAT
> peripheral device. This board is an add on for the Raspberry Pi that is
> designed to connect using the GPIO connector and communicate via I2C.
>
> It features:
> 	- a joystick
> 	- an 8x8 RGB LED matrix display
> 	- a whole bunch of environmental sensors with their own drivers
> 	  (those are already in upstream Linux)
>
> This is a refactor of the work of Serge Schneider, the author of a
> version of this driver that is currently in the Raspberry Pi downstream
> kernel. We modified his code to make it suitable for upstream Linux.
>
> A couple of tests are available for the driver in the test folder in
> this repo: https://github.com/underground-software/sensehat.git
> 	- sensehat_joystick_test logs the input events from the
> 	  joystick to the console
> 	- sensehat_display_test displays various solid colors on
> 	  the LED panel.
> 	- full_sensehat_test displays a single lit cell that can be
> 	  moved with the joystick. Pressing the joystick ends the
> 	  program.
>
> For more information about the Sense HAT, visit:
> https://www.raspberrypi.org/products/sense-hat/
>
> Changes since v8:
> 	- Fixed a few small things in the device tree bindings.
> 	I forgot to include the fact that Rob Herring had already
> 	reviewed them when I posted v8, so Krzysztof Kozlowski
> 	jumped in and offered his input. The suggestions were good
> 	so we decided to include them. Sorry for the confusion.
> 	- Corrected a typo in the description of the display driver.
> 	The format of the special file used by the driver was changed
> 	in v8 and this was described in the cover letter of the patch,
> 	but not in the actual note attached to that patch. This is now
> 	fixed.
>
> Co-developed-by: Daniel Bauman <dbauman@...hat.com>
> Signed-off-by: Daniel Bauman <dbauman@...hat.com>
> Co-developed-by: Mwesigwa Guma <mguma@...hat.com>
> Signed-off-by: Mwesigwa Guma <mguma@...hat.com>
> Co-developed-by: Joel Savitz <jsavitz@...hat.com>
> Signed-off-by: Joel Savitz <jsavitz@...hat.com>
> Signed-off-by: Charles Mirabile <cmirabil@...hat.com>
>
> Charles Mirabile (6):
>    drivers/mfd: sensehat: Add Raspberry Pi Sense HAT to simple_mfd_i2c
>    drivers/input/joystick: sensehat: Raspberry Pi Sense HAT joystick
>      driver
>    drivers/auxdisplay: sensehat: Raspberry Pi Sense HAT display driver
>    dt-bindings: mfd: sensehat: Add Raspberry Pi Sense HAT schema
>    MAINTAINERS: Add sensehat driver authors to MAINTAINERS
>    DO NOT MERGE: full sensehat device tree overlay for raspberry pi 4

since only the joystick patch has been applied, could you please send a 
rebased v10 without the joystick driver?

Please take care of the fact that Florian is the new BCM2835 maintainer.

Thanks