[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <78c29f43-3b67-8e70-0711-14e997f3efb1@gmail.com>
Date: Thu, 23 Jun 2022 09:47:48 +0200
From: Böszörményi Zoltán <zboszor@...il.com>
To: Damien Le Moal <damien.lemoal@...nsource.wdc.com>, zboszor@...hu,
linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: [PATCH] libata: add horkage for M88V29
2022. 02. 08. 9:07 keltezéssel, Damien Le Moal írta:
> On 2/4/22 21:57, zboszor@...hu wrote:
>> From: Zoltán Böszörményi <zboszor@...il.com>
>>
>> This device is a CF card, or possibly an SSD in CF form factor.
>> It supports NCQ and high speed DMA.
>>
>> While it also advertises TRIM support, I/O errors are reported
>> when the discard mount option fstrim is used. TRIM also fails
>> when disabling NCQ and not just as an NCQ command.
>>
>> TRIM must be disabled for this device.
>>
>> Signed-off-by: Zoltán Böszörményi <zboszor@...il.com>
>> ---
>> drivers/ata/libata-core.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
>> index 67f88027680a..4a7f58fcc411 100644
>> --- a/drivers/ata/libata-core.c
>> +++ b/drivers/ata/libata-core.c
>> @@ -4028,6 +4028,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>>
>> /* devices that don't properly handle TRIM commands */
>> { "SuperSSpeed S238*", NULL, ATA_HORKAGE_NOTRIM, },
>> + { "M88V29*", NULL, ATA_HORKAGE_NOTRIM, },
>>
>> /*
>> * As defined, the DRAT (Deterministic Read After Trim) and RZAT
> Applied to for-5.17-fixes. Thanks !
Thank you. However, I have second thoughts about this patch.
The device advertises this:
# hdparm -iI /dev/sda
...
Enabled Supported
* Data Set Management TRIM supported (limit 1 block)
...
but the I/O failures always reported higher number of blocks,
IIRC the attempted number of block was 8 or so.
Can the kernel limit or split TRIM commands according to the
advertised limit? If not (or not yet) then the quirk is good for now.
Best regards,
Zoltán Böszörményi
Powered by blists - more mailing lists