linux-kernel - Re: linux-next: Fixes tag needs some work in the block tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <587b0d70ac117e7eb2b6b1f2e0f6996c9f960c53.camel@fb.com>
Date:   Thu, 23 Jun 2022 08:11:10 +0000
From:   Dylan Yudaken <dylany@...com>
To:     "sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
        "axboe@...nel.dk" <axboe@...nel.dk>
CC:     "linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the block tree

On Wed, 2022-06-22 at 17:44 -0600, Jens Axboe wrote:
> On 6/22/22 5:21 PM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >   1da6baa4e4c2 ("io_uring: move io_uring_get_opcode out of
> > TP_printk")
> > 
> > Fixes tag
> > 
> >   Fixes: 033b87d2 ("io_uring: use the text representation of ops in
> > trace")
> > 
> > has these problem(s):
> > 
> >   - SHA1 should be at least 12 digits long
> >     This can be fixed for the future by setting core.abbrev to 12
> > (or
> >     more) or (for git v2.11 or later) just making sure it is not
> > set
> >     (or set to "auto").
> 
> I'll rebase on -rc4 anyway, I'll fix thie one up.
> 
> Dylan, here's what I use for adding Fixes tags:
> 
> [pretty]
>         fixes = Fixes: %h (\"%s\")
> 
> and then I just do:
> 
> git fixes 033b87d2
> Fixes: 033b87d24f72 ("io_uring: use the text representation of ops in
> trace")
> 
> to generate it.
> 

Thanks! I'll automate it next time as obviously by hand is nuts

Dylan