linux-kernel - Re: [PATCH] soc: mediatek: mutex: add suffix 0 to DDP_COMPONENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ff4dc55c-bb87-ac15-2d39-1f1ed41f4221@collabora.com>
Date:   Thu, 23 Jun 2022 10:13:23 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Jason-JH Lin <jason-jh.lin@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Fabien Parent <fparent@...libre.com>
Cc:     CK Hu <ck.hu@...iatek.com>, Rex-BC Chen <rex-bc.chen@...iatek.com>,
        Nancy Lin <nancy.lin@...iatek.com>,
        Singo Chang <singo.chang@...iatek.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH] soc: mediatek: mutex: add suffix 0 to
 DDP_COMPONENT_DITHER for mt8395

Il 23/06/22 02:33, Jason-JH Lin ha scritto:
> Hi Angelo,
> 
> Yes, I missed that!
> So just forget about this patch and use yours.
> 
> Thanks for your help :)
> 

No worries, it happens...
Btw, you're welcome.

Cheers!

> Regard,
> Jason-JH.Lin
> 
> On Wed, 2022-06-22 at 15:31 +0200, AngeloGioacchino Del Regno wrote:
>> Il 22/06/22 15:19, Jason-JH.Lin ha scritto:
>>> Add suffix 0 to DDP_COMPONENT_DITHER for mt8395.
>>>
>>> Fixes: 141311b856d8 ("soc: mediatek: mutex: add MT8365 support")
>>> Signed-off-by: Jason-JH.Lin <jason-jh.lin@...iatek.com>
>>
>>
>> Hello Jason-JH,
>>
>> you must've missed my commit, sent two days ago, which is doing the
>> same:
>>
>>
> https://lore.kernel.org/lkml/20220620102454.131417-1-angelogioacchino.delregno@collabora.com/T/#u
>>
>> Anyway, I have avoided to rename the definition, as from what I
>> understand
>> MT8365 has only one dither mod and that's called "DITHER", not
>> "DITHER0"...
>> ...but I've added the suffix to the array assignment, as that's what
>> we have
>> in the enumeration.
>>
>> I think that #define MT8365_MUTEX_MOD_DISP_DITHER should be kept as-
>> is.
>>
>> Also... this commit is not fixing anything, as it was already working
>> before,
>> so the Fixes tag shouldn't be present.
>>
>> Regards,
>> Angelo
>>