linux-kernel - Re: [PATCH 33/49] mfd: rohm-bd718x7: drop useless mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <704886e7-7aa0-ca57-2ce9-a86d9cde4a4b@fi.rohmeurope.com>
Date:   Thu, 23 Jun 2022 09:09:16 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     Aidan MacDonald <aidanmacdonald.0x0@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>
CC:     "agross@...nel.org" <agross@...nel.org>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "srinivas.kandagatla@...aro.org" <srinivas.kandagatla@...aro.org>,
        "bgoswami@...eaurora.org" <bgoswami@...eaurora.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "cw00.choi@...sung.com" <cw00.choi@...sung.com>,
        "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
        "b.zolnierkie@...sung.com" <b.zolnierkie@...sung.com>,
        "myungjoo.ham@...sung.com" <myungjoo.ham@...sung.com>,
        "michael@...le.cc" <michael@...le.cc>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "brgl@...ev.pl" <brgl@...ev.pl>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "maz@...nel.org" <maz@...nel.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "mani@...nel.org" <mani@...nel.org>,
        "cristian.ciocaltea@...il.com" <cristian.ciocaltea@...il.com>,
        "wens@...e.org" <wens@...e.org>,
        "tharvey@...eworks.com" <tharvey@...eworks.com>,
        "rjones@...eworks.com" <rjones@...eworks.com>,
        "mazziesaccount@...il.com" <mazziesaccount@...il.com>,
        "orsonzhai@...il.com" <orsonzhai@...il.com>,
        "baolin.wang7@...il.com" <baolin.wang7@...il.com>,
        "zhang.lyra@...il.com" <zhang.lyra@...il.com>,
        "jernej.skrabec@...il.com" <jernej.skrabec@...il.com>,
        "samuel@...lland.org" <samuel@...lland.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-actions@...ts.infradead.org" 
        <linux-actions@...ts.infradead.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-sunxi@...ts.linux.dev" <linux-sunxi@...ts.linux.dev>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Subject: Re: [PATCH 33/49] mfd: rohm-bd718x7: drop useless mask_invert flag on
 irqchip

On 6/20/22 23:06, Aidan MacDonald wrote:
> There's no need to set the flag explicitly to false, since that
> is the default value from zero initialization.
> 
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@...il.com>
> ---
>   drivers/mfd/rohm-bd718x7.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mfd/rohm-bd718x7.c b/drivers/mfd/rohm-bd718x7.c
> index bfd81f78beae..ad6c0971a997 100644
> --- a/drivers/mfd/rohm-bd718x7.c
> +++ b/drivers/mfd/rohm-bd718x7.c
> @@ -70,7 +70,6 @@ static struct regmap_irq_chip bd718xx_irq_chip = {
>   	.mask_base = BD718XX_REG_MIRQ,
>   	.ack_base = BD718XX_REG_IRQ,
>   	.init_ack_masked = true,
> -	.mask_invert = false,
>   };
>   
>   static const struct regmap_range pmic_status_range = {

Reviewed-by: Matti Vaittinen <mazziesaccount@...il.com>

-- 
The Linux Kernel guy at ROHM Semiconductors

Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~ this year is the year of a signature writers block ~~