[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YrQw1CVJfIS18CNo@electric-eye.fr.zoreil.com>
Date: Thu, 23 Jun 2022 11:22:28 +0200
From: Francois Romieu <romieu@...zoreil.com>
To: Tong Zhang <ztong0001@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Florian Fainelli <f.fainelli@...il.com>,
Arnd Bergmann <arnd@...db.de>, Jason Gunthorpe <jgg@...pe.ca>,
Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
Yilun Wu <yiluwu@...stonybrook.edu>
Subject: Re: [PATCH] epic100: fix use after free on rmmod
Tong Zhang <ztong0001@...il.com> :
> epic_close() calls epic_rx() and uses dma buffer, but in epic_remove_one()
> we already freed the dma buffer. To fix this issue, reorder function calls
> like in the .probe function.
>
> BUG: KASAN: use-after-free in epic_rx+0xa6/0x7e0 [epic100]
> Call Trace:
> epic_rx+0xa6/0x7e0 [epic100]
> epic_close+0xec/0x2f0 [epic100]
> unregister_netdev+0x18/0x20
> epic_remove_one+0xaa/0xf0 [epic100]
>
> Fixes: ae150435b59e ("smsc: Move the SMC (SMSC) drivers")
> Reported-by: Yilun Wu <yiluwu@...stonybrook.edu>
> Signed-off-by: Tong Zhang <ztong0001@...il.com>
The "Fixes:" tag is a bit misleading: this code path predates the move
by several years. Ignoring pci_* vs dma_* API changes, this is pre-2005
material.
Reviewed-by: Francois Romieu <romieu@...zoreil.com>
--
Ueimor
Powered by blists - more mailing lists