[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VdSadbtkH1JeiPuJ_CSBDq82GaRWLvJFd8Egg7poY8Lxw@mail.gmail.com>
Date: Thu, 23 Jun 2022 12:17:58 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Jiri Slaby <jirislaby@...nel.org>
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
Greg KH <gregkh@...uxfoundation.org>,
Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
William Hubbs <w.d.hubbs@...il.com>,
Chris Brannon <chris@...-brannons.com>,
Kirk Reiser <kirk@...sers.ca>,
Samuel Thibault <samuel.thibault@...-lyon.org>,
"David S. Miller" <davem@...emloft.net>,
"linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"speakup@...ux-speakup.org" <speakup@...ux-speakup.org>,
"sparclinux@...r.kernel.org" <sparclinux@...r.kernel.org>
Subject: Re: [PATCH v2 6/6] serial: Consolidate BOTH_EMPTY use
On Thu, Jun 23, 2022 at 12:15 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Thu, Jun 23, 2022 at 10:24 AM Jiri Slaby <jirislaby@...nel.org> wrote:
> > On 23. 06. 22, 10:11, Andy Shevchenko wrote:
> > > * prom_putchar_wait() should be implemented using
> > > read_poll_timeout_atomic(), incl. failure/timeout handling.
> > >
> > > Not sure since it is an early stage and scheduler might not work as
> > > expected. Conversions to iopoll.h macros bitten us a few times already.
> >
> > Except _atomic does not use scheduler :).
>
> Sorry for a bit misleading comment, but I chased it down, so this what
> I had in mind when commenting:
> be24c6a71ecf ("soc: qcom: rpmh-rsc: Don't use ktime for timeout in
> write_tcs_reg_sync()")
...and this one (specifically for early stages)
c4d936efa46d ("Revert "usb: early: convert to readl_poll_timeout_atomic()"")
> (Yes, it's about _atomic variant)
>
> Means we need to use those macros with care.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists