linux-kernel - Re: [PATCH] rpmsg: fix possible refcount leak in rpmsg_register_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <42ff7e04-5e32-7fee-d874-a983dcede4a0@linaro.org>
Date:   Thu, 23 Jun 2022 12:57:07 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Hangyu Hua <hbh25y@...il.com>, bjorn.andersson@...aro.org,
        mathieu.poirier@...aro.org, gregkh@...uxfoundation.org
Cc:     linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rpmsg: fix possible refcount leak in
 rpmsg_register_device_override()

On 23/06/2022 12:53, Hangyu Hua wrote:
> On 2022/6/23 16:15, Krzysztof Kozlowski wrote:
>> On 23/06/2022 09:36, Hangyu Hua wrote:
>>> [1] commit 1680939e9ecf ("rpmsg: virtio: Fix possible double free in
>>> rpmsg_virtio_add_ctrl_dev()")
>>> [2] commit c2eecefec5df ("rpmsg: virtio: Fix possible double free in
>>> rpmsg_probe()")
>>> [3] commit bb17d110cbf2 ("rpmsg: Fix calling device_lock() on
>>> non-initialized device")
>>
>> I think only the last [3] introduced it, because it's the commit missing
>> put_device in first error path.
>>
> 
> I see. Do i need to change the commit log and then send a v2?

Yes, please. With my Reviewed-by tag.


Best regards,
Krzysztof