Message-ID: <878rpny47v.fsf@redhat.com>
Date:   Thu, 23 Jun 2022 14:05:56 +0200
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     Paolo Bonzini <pbonzini@...hat.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Cc:     Sean Christopherson <seanjc@...gle.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>
Subject: Re: [PATCH] MAINTAINERS: Reorganize KVM/x86 maintainership

Paolo Bonzini <pbonzini@...hat.com> writes:

> For the last few years I have been the sole maintainer of KVM, albeit
> getting serious help from all the people who have reviewed hundreds of
> patches.  The volume of KVM x86 alone has gotten to the point where one
> maintainer is not enough; especially if that maintainer is not doing it
> full time and if they want to keep up with the evolution of ARM64 and
> RISC-V at both the architecture and the hypervisor level.
>
> So, this patch is the first step in restoring double maintainership
> or even transitioning to the submaintainer model of other architectures.
>
> The changes here were mostly proposed by Sean offlist and they are twofold:
>
> - revisiting the set of KVM x86 reviewers.  It's important to have an
>   an accurate list of people that are actively reviewing patches ("R"),
>   as well as people that are able to act on bug reports ("M").  Otherwise,
>   voids to be filled are not easily visible.  The proposal is to split
>   KVM on Hyper-V, which is where Vitaly has been the main contributor
>   for quite some time now; likewise for KVM paravirt support, which
>   has been the main interest of Wanpeng.  Jim and Joerg have not been
>   particularly active (though Joerg has worked on guest support for AMD
>   SEV); knowing them a bit, I can't imagine they would object to their
>   removal or even be surprised, but please speak up if you do.
>
> - promoting Sean to maintainer for KVM x86 host support.  While for
>   now this changes little, let's treat it as a harbinger for future
>   changes.  The plan is that I would keep the final integration testing
>   for quite some time, and probably focus more on -rc work.  This will
>   give me more time to clean up my ad hoc setup and moving towards a
>   more public CI, with Sean focusing instead on next-release patches,
>   and the testing up to where kvm-unit-tests and selftests pass.  In
>   order to facilitate collaboration between Sean and myself, we'll
>   also formalize a bit more the various branches of kvm.git.
>
> Nothing is going to change with respect to handling pull requests to Linus
> and from other architectures, as well as maintainance of the generic code
> (which I expect and hope to be more important as architectures try to
> share more code) and documentation.  However, it's not a coincidence
> that my entry is now the last for x86, ready to be demoted to reviewer
> if/when the right time comes.
>
> (Man, this commit message sounds emotional).
>
> Suggested-by: Sean Christopherson <seanjc@...gle.com>
> Co-developed-by: Sean Christopherson <seanjc@...gle.com>
> Cc: kvm@...r.kernel.org
> Cc: Sean Christopherson <seanjc@...gle.com>
> Cc: Vitaly Kuznetsov <vkuznets@...hat.com>
> Cc: Wanpeng Li <wanpengli@...cent.com>
> Cc: Jim Mattson <jmattson@...gle.com>
> Cc: Joerg Roedel <joro@...tes.org>
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
> ---
>  MAINTAINERS | 37 ++++++++++++++++++++++++++++---------
>  1 file changed, 28 insertions(+), 9 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 97014ae3e5ed..3f7c485195d9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10897,28 +10897,47 @@ F:	tools/testing/selftests/kvm/*/s390x/
>  F:	tools/testing/selftests/kvm/s390x/
>  
>  KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86)
> +M:	Sean Christopherson <seanjc@...gle.com>
>  M:	Paolo Bonzini <pbonzini@...hat.com>
> -R:	Sean Christopherson <seanjc@...gle.com>
> -R:	Vitaly Kuznetsov <vkuznets@...hat.com>
> -R:	Wanpeng Li <wanpengli@...cent.com>
> -R:	Jim Mattson <jmattson@...gle.com>
> -R:	Joerg Roedel <joro@...tes.org>
>  L:	kvm@...r.kernel.org
>  S:	Supported
> -W:	http://www.linux-kvm.org
>  T:	git git://git.kernel.org/pub/scm/virt/kvm/kvm.git
>  F:	arch/x86/include/asm/kvm*
> -F:	arch/x86/include/asm/pvclock-abi.h
>  F:	arch/x86/include/asm/svm.h
>  F:	arch/x86/include/asm/vmx*.h
>  F:	arch/x86/include/uapi/asm/kvm*
>  F:	arch/x86/include/uapi/asm/svm.h
>  F:	arch/x86/include/uapi/asm/vmx.h
> -F:	arch/x86/kernel/kvm.c
> -F:	arch/x86/kernel/kvmclock.c
>  F:	arch/x86/kvm/
>  F:	arch/x86/kvm/*/
>  
> +KVM PARAVIRT (KVM/paravirt)
> +M:	Paolo Bonzini <pbonzini@...hat.com>
> +R:	Wanpeng Li <wanpengli@...cent.com>
> +L:	kvm@...r.kernel.org
> +S:	Supported
> +T:	git git://git.kernel.org/pub/scm/virt/kvm/kvm.git
> +F:	arch/x86/kernel/kvm.c
> +F:	arch/x86/kernel/kvmclock.c
> +F:	arch/x86/include/asm/pvclock-abi.h
> +F:	include/linux/kvm_para.h
> +F:	include/uapi/linux/kvm_para.h
> +F:	include/uapi/asm-generic/kvm_para.h
> +F:	include/asm-generic/kvm_para.h
> +F:	arch/um/include/asm/kvm_para.h
> +F:	arch/x86/include/asm/kvm_para.h
> +F:	arch/x86/include/uapi/asm/kvm_para.h

If we add Async PF to the 'KVM/paravirt' scope:

+F:   virt/kvm/async_pf.c
and maybe even
+F:   arch/x86/kvm/x86.c

then I can probably volunteer as a reviewer.

> +
> +KVM X86 HYPER-V (KVM/hyper-v)
> +M:	Vitaly Kuznetsov <vkuznets@...hat.com>
> +M:	Sean Christopherson <seanjc@...gle.com>
> +M:	Paolo Bonzini <pbonzini@...hat.com>

Don't we also need:

S:   Supported
L:   kvm@...r.kernel.org

here?

> +T:	git git://git.kernel.org/pub/scm/virt/kvm/kvm.git
> +F:	arch/x86/kvm/hyperv.*
> +F:	arch/x86/kvm/kvm_onhyperv.*
> +F:	arch/x86/kvm/svm/svm_onhyperv.*

+F:   arch/x86/kvm/svm/hyperv.*

> +F:	arch/x86/kvm/vmx/evmcs.*
> +
>  KERNFS
>  M:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>  M:	Tejun Heo <tj@...nel.org>

-- 
Vitaly

Powered by blists - more mailing lists