linux-kernel - Re: [PATCH] virtio_fs: Modify format for virtio_fs_direct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YrRhAZA1Enez0WRA@redhat.com>
Date:   Thu, 23 Jun 2022 08:48:01 -0400
From:   Vivek Goyal <vgoyal@...hat.com>
To:     Deming Wang <wangdeming@...pur.com>
Cc:     stefanha@...hat.com, miklos@...redi.hu,
        virtualization@...ts.linux-foundation.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virtio_fs: Modify format for virtio_fs_direct_access

On Wed, Jun 22, 2022 at 05:17:58PM -0400, Deming Wang wrote:
> We should isolate operators with spaces.
> 
> Signed-off-by: Deming Wang <wangdeming@...pur.com>

Looks good to me.

Reviewed-by: Vivek Goyal <vgoyal@...hat.com>

Vivek

> ---
>  fs/fuse/virtio_fs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
> index 8db53fa67359..e962c29967eb 100644
> --- a/fs/fuse/virtio_fs.c
> +++ b/fs/fuse/virtio_fs.c
> @@ -757,7 +757,7 @@ static long virtio_fs_direct_access(struct dax_device *dax_dev, pgoff_t pgoff,
>  {
>  	struct virtio_fs *fs = dax_get_private(dax_dev);
>  	phys_addr_t offset = PFN_PHYS(pgoff);
> -	size_t max_nr_pages = fs->window_len/PAGE_SIZE - pgoff;
> +	size_t max_nr_pages = fs->window_len / PAGE_SIZE - pgoff;
>  
>  	if (kaddr)
>  		*kaddr = fs->window_kaddr + offset;
> -- 
> 2.27.0
>