linux-kernel - Re: [PATCH] pstore/zone: cleanup "rcnt" type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165599826298.1932382.1524111439094870680.b4-ty@chromium.org>
Date:   Thu, 23 Jun 2022 08:31:05 -0700
From:   Kees Cook <keescook@...omium.org>
To:     dan.carpenter@...cle.com, gmpy.liaowx@...il.com
Cc:     Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org,
        anton@...msg.org, ccross@...roid.com,
        Tony Luck <tony.luck@...el.com>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] pstore/zone: cleanup "rcnt" type

On Thu, 23 Jun 2022 16:40:13 +0300, Dan Carpenter wrote:
> The info->read() function returns ssize_t.  That means that info->read()
> either returns either negative error codes or a positive number
> representing the bytes read.
> 
> The "rcnt" variable should be declared as ssize_t as well.  Most places
> do this correctly but psz_kmsg_recover_meta() needed to be fixed.
> 
> [...]

Applied to for-next/pstore, thanks!

[1/1] pstore/zone: cleanup "rcnt" type
      https://git.kernel.org/kees/c/2c09d1443b9b

-- 
Kees Cook