linux-kernel - Re: [PATCH v3 1/9] pstore: Add priv field to pstore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202206241029.9C0891C5B6@keescook>
Date:   Fri, 24 Jun 2022 10:30:23 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Ard Biesheuvel <ardb@...nel.org>
Cc:     linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Matthew Garrett <mjg59@...f.ucam.org>,
        Peter Jones <pjones@...hat.com>, Jeremy Kerr <jk@...abs.org>,
        Tony Luck <tony.luck@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>
Subject: Re: [PATCH v3 1/9] pstore: Add priv field to pstore_record for
 backend specific use

On Fri, Jun 24, 2022 at 10:49:17AM +0200, Ard Biesheuvel wrote:
> The EFI pstore backend will need to store per-record variable name data
> when we switch away from the efivars layer. Add a priv field to struct
> pstore_record, and document it as holding a backend specific pointer
> that is assumed to be a kmalloc()d buffer, and will be kfree()d when the
> entire record is freed.
> 
> Signed-off-by: Ard Biesheuvel <ardb@...nel.org>

I'm a fan! This is useful, and I'll likely try to use it for some of the
RAM-specific things too. :)

Acked-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook