linux-kernel - Re: [PATCH 3/3] KVM: x86/mmu: Buffer nested MMU split_desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YrX20hfudgMQ/6ns@google.com>
Date:   Fri, 24 Jun 2022 17:39:30 +0000
From:   David Matlack <dmatlack@...gle.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] KVM: x86/mmu: Buffer nested MMU split_desc_cache
 only by default capacity

On Fri, Jun 24, 2022 at 05:18:08PM +0000, Sean Christopherson wrote:
> Buffer split_desc_cache, the cache used to allcoate rmap list entries,
> only by the default cache capacity (currently 40), not by doubling the
> minimum (513).  Aliasing L2 GPAs to L1 GPAs is uncommon, thus eager page
> splitting is unlikely to need 500+ entries.  And because each object is a
> non-trivial 128 bytes (see struct pte_list_desc), those extra ~500
> entries means KVM is in all likelihood wasting ~64kb of memory per VM.
> 
> Link: https://lore.kernel.org/all/YrTDcrsn0%2F+alpzf@google.com
> Cc: David Matlack <dmatlack@...gle.com>
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>

Thanks for the cleanups!

Reviewed-by: David Matlack <dmatlack@...gle.com>