linux-kernel - Re: [PATCH v2 3/3] drm/panel: sony-acx565akm: Use backlight helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YrYS06BYJbnCGGJn@ravnborg.org>
Date:   Fri, 24 Jun 2022 21:38:59 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Stephen Kitt <steve@....org>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        David Airlie <airlied@...ux.ie>,
        Sebastian Reichel <sebastian.reichel@...labora.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] drm/panel: sony-acx565akm: Use backlight helpers

On Thu, Jun 16, 2022 at 07:23:15PM +0200, Stephen Kitt wrote:
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
> 
> Instead of manually checking the power state in struct
> backlight_properties, use backlight_is_blank().
> 
> While we're at it, drop .fb_blank from the initialisation function; it
> is deprecated, and this helps make progress towards enabling its
> removal. This change makes no functional difference since
> FB_BLANK_UNBLANK is the default value.
> 
> Signed-off-by: Stephen Kitt <steve@....org>
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: Sam Ravnborg <sam@...nborg.org>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: dri-devel@...ts.freedesktop.org
Thanks, applied to drm-misc (drm-misc-next)

	Sam