linux-kernel - Re: [PATCH v2] drm: bridge: adv7511: Add check for mipi_dsi_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YrYfmqJbRmGWh0qw@ravnborg.org>
Date:   Fri, 24 Jun 2022 22:33:30 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc:     laurent.pinchart@...asonboard.com, jagan@...rulasolutions.com,
        jonas@...boo.se, airlied@...ux.ie, dri-devel@...ts.freedesktop.org,
        narmstrong@...libre.com, linux-kernel@...r.kernel.org,
        jernej.skrabec@...il.com, robert.foss@...aro.org,
        andrzej.hajda@...el.com, alsi@...g-olufsen.dk,
        biju.das.jz@...renesas.com, maxime@...no.tech
Subject: Re: [PATCH v2] drm: bridge: adv7511: Add check for
 mipi_dsi_driver_register

On Thu, Jun 02, 2022 at 06:34:01PM +0800, Jiasheng Jiang wrote:
> As mipi_dsi_driver_register could return error if fails,
> it should be better to check the return value and return error
> if fails.
> Moreover, if i2c_add_driver fails,  mipi_dsi_driver_register
> should be reverted.
> 
> Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device")
> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>

Thanks, added to drm-misc (added to drm-misc-next as this did not look
like something that required fast forward to mainline).

	Sam