linux-kernel - [PATCH] blk-mq: remove unnecessary variables in blk_mq_init_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1656041424-50894-1-git-send-email-liusong@linux.alibaba.com>
Date:   Fri, 24 Jun 2022 11:30:24 +0800
From:   Liu Song <liusong@...ux.alibaba.com>
To:     axboe@...nel.dk
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] blk-mq: remove unnecessary variables in blk_mq_init_cpu_queues

From: Liu Song <liusong@...ux.alibaba.com>

Remove unnecessary variables and adjust code style to be the same as
other functions in blk-mq.c, no functional modification involved.

Signed-off-by: Liu Song <liusong@...ux.alibaba.com>
---
 block/blk-mq.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index e9bf950..c71119d 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -3579,19 +3579,18 @@ static void blk_mq_init_cpu_queues(struct request_queue *q,
 				   unsigned int nr_hw_queues)
 {
 	struct blk_mq_tag_set *set = q->tag_set;
+	struct blk_mq_ctx *ctx;
+	struct blk_mq_hw_ctx *hctx;
 	unsigned int i, j;
 
 	for_each_possible_cpu(i) {
-		struct blk_mq_ctx *__ctx = per_cpu_ptr(q->queue_ctx, i);
-		struct blk_mq_hw_ctx *hctx;
-		int k;
-
-		__ctx->cpu = i;
-		spin_lock_init(&__ctx->lock);
-		for (k = HCTX_TYPE_DEFAULT; k < HCTX_MAX_TYPES; k++)
-			INIT_LIST_HEAD(&__ctx->rq_lists[k]);
+		ctx = per_cpu_ptr(q->queue_ctx, i);
+		ctx->cpu = i;
+		ctx->queue = q;
 
-		__ctx->queue = q;
+		spin_lock_init(&ctx->lock);
+		for (j = HCTX_TYPE_DEFAULT; j < HCTX_MAX_TYPES; j++)
+			INIT_LIST_HEAD(&ctx->rq_lists[j]);
 
 		/*
 		 * Set local node, IFF we have more than one hw queue. If
-- 
1.8.3.1