linux-kernel - Re: [PATCH 1/6] ksmbd: use vfs_llseek instead of dereferencing NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YrYqp1eaxEcQxIeo@ZenIV>
Date:   Fri, 24 Jun 2022 22:20:39 +0100
From:   Al Viro <viro@...iv.linux.org.uk>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
        linux-fsdevel@...r.kernel.org, stable@...r.kernel.org,
        linux-cifs@...r.kernel.org, Namjae Jeon <namjae.jeon@...sung.com>,
        Steve French <stfrench@...rosoft.com>,
        Ronnie Sahlberg <lsahlber@...hat.com>,
        Hyunchul Lee <hyc.lee@...il.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH 1/6] ksmbd: use vfs_llseek instead of dereferencing NULL

On Fri, Jun 24, 2022 at 06:56:26PM +0200, Jason A. Donenfeld wrote:
> By not checking whether llseek is NULL, this might jump to NULL. Also,
> it doesn't check FMODE_LSEEK. Fix this by using vfs_llseek(), which
> always does the right thing.

Acked-by: Al Viro <viro@...iv.linux.org.uk>