linux-kernel - Re: [PATCH] of: base: Remove duplicate 'of' in two places.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14a9c8fe-410e-2c85-7d1e-733222d1902c@gmail.com>
Date:   Thu, 23 Jun 2022 22:59:29 -0500
From:   Frank Rowand <frowand.list@...il.com>
To:     Jiang Jian <jiangjian@...rlc.com>, robh+dt@...nel.org
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: base: Remove duplicate 'of' in two places.

On 6/21/22 12:13, Jiang Jian wrote:
> file: drivers/of/base.c
> line: 1152,1177
> * @matches:    array of of device match structures to search in
> changed to
> * @matches:    array of device match structures to search in
> 
> Signed-off-by: Jiang Jian <jiangjian@...rlc.com>
> ---
>  drivers/of/base.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index d4f98c8469ed..f738939cd283 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -1149,7 +1149,7 @@ const struct of_device_id *__of_match_node(const struct of_device_id *matches,
>  
>  /**
>   * of_match_node - Tell if a device_node has a matching of_match structure
> - * @matches:	array of of device match structures to search in
> + * @matches:	array of device match structures to search in
>   * @node:	the of device structure to match against
>   *
>   * Low level utility function used by device matching.
> @@ -1174,7 +1174,7 @@ EXPORT_SYMBOL(of_match_node);
>   *		you pass will not be searched, only the next one
>   *		will; typically, you pass what the previous call
>   *		returned. of_node_put() will be called on it
> - * @matches:	array of of device match structures to search in
> + * @matches:	array of device match structures to search in
>   * @match:	Updated to point at the matches entry which matched
>   *
>   * Return: A node pointer with refcount incremented, use

"of of device" looks wrong, but 'of device' means Open Firmeare device.
So technically it is correct.  If Rob wants to accept the patch then
I am ok with the acceptance, to avoid future attempts to fix.

Reviewed-by: Frank Rowand <frank.rowand@...y.com>