linux-kernel - Re: [PATCH 1/2] clk: pistachio: Fix initconst confusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220624004225.0DE4AC3411D@smtp.kernel.org>
Date:   Thu, 23 Jun 2022 17:42:23 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Jiri Slaby <jslaby@...e.cz>, mturquette@...libre.com
Cc:     mliska@...e.cz, linux-kernel@...r.kernel.org,
        Andi Kleen <ak@...ux.intel.com>, linux-clk@...r.kernel.org,
        Jiri Slaby <jslaby@...e.cz>
Subject: Re: [PATCH 1/2] clk: pistachio: Fix initconst confusion

Quoting Jiri Slaby (2022-06-23 01:32:16)
> From: Andi Kleen <ak@...ux.intel.com>
> 
> A variable pointing to const isn't const itself. It'd have to contain
> "const" keyword after "*" too. Therefore, PNAME() cannot put the strings
> to "rodata".  Hence use __initdata instead of __initconst to fix this.
> 
> [js] more explanatory commit message.
> 
> Cc: Michael Turquette <mturquette@...libre.com>
> Cc: Stephen Boyd <sboyd@...nel.org>
> Cc: linux-clk@...r.kernel.org
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> ---
>  drivers/clk/pistachio/clk.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/pistachio/clk.h b/drivers/clk/pistachio/clk.h
> index f9c31e3a0e47..742e5fab00c0 100644
> --- a/drivers/clk/pistachio/clk.h
> +++ b/drivers/clk/pistachio/clk.h
> @@ -34,7 +34,7 @@ struct pistachio_mux {
>         const char **parents;
>  };
>  
> -#define PNAME(x) static const char *x[] __initconst
> +#define PNAME(x) static const char *x[] __initdata

Can it be const char * const and left as __initconst?