linux-kernel - Re: [PATCH 2/2] platform/x86: panasonic-laptop: allow to use all hotkeys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPqSeKsfujjOKPg9nrs0XXt4Bbxt8j_+rY4VCT--NZZ-7XfgiQ@mail.gmail.com>
Date:   Fri, 24 Jun 2022 13:14:10 +0800
From:   Kenneth Chan <kenneth.t.chan@...il.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Stefan Seyfried <stefan.seyfried@...glemail.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Stefan Seyfried <seife+kernel@...systems.com>
Subject: Re: [PATCH 2/2] platform/x86: panasonic-laptop: allow to use all hotkeys

Hi Hans,


On Tue, 21 Jun 2022 at 17:34, Hans de Goede <hdegoede@...hat.com> wrote:
>
>
> > The mute, volume up/down keys are still duplicated by atkbd after
> > applying 0005-platform-x86-panasonic-laptop-filter-out-duplicate-v.patch.
>
> Hmm, can you add a couple of:
>
>  pr_info("data 0x%02x\n", data);
>
> at the top of the new panasonic_i8042_filter() function
> and then check in dmesg what is output for the volume keys.
>

Volume Down 0xe0 0x2e / 0xe0 0xae
Mute 0xe0 0x20 / 0xe0 0xa0
Volume Up 0xe0 0x30 / 0xe0 0xb0

I replaced those values with these and it filters out the duplicate keys. Yay!!!

>
> The patch should filter out those duplicate keys, unless
> I got the codes wrong somehow.
>
> Also can you please try the attached 2 patches on top of my
> last series, this should hide the broken panasonic backlight
> device and otherwise it should make no difference (but maybe
> double check the duplicate brightness keys are not back.
>

The last 2 patches crash as soon as the panasonic-laptop module is
loaded. It's compiled against kernel v5.18.5. Please see the
attachment. I'm going to compile it against the latest and see if it
works.

-- 
Kenneth

View attachment "DMESG.txt" of type "text/plain" (51489 bytes)