linux-kernel - Re: [PATCH v2] perf test: Add ARM SPE system wide test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM9d7ci8pLo=dKFgF8O8610eHTx532d+1TKTf18ibPMtdZp5Lg@mail.gmail.com>
Date:   Thu, 23 Jun 2022 23:22:16 -0700
From:   Namhyung Kim <namhyung@...nel.org>
To:     Leo Yan <leo.yan@...aro.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>, Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Ian Rogers <irogers@...gle.com>,
        linux-perf-users <linux-perf-users@...r.kernel.org>,
        John Garry <john.garry@...wei.com>,
        Will Deacon <will@...nel.org>,
        James Clark <james.clark@....com>,
        Mike Leach <mike.leach@...aro.org>,
        German Gomez <german.gomez@....com>
Subject: Re: [PATCH v2] perf test: Add ARM SPE system wide test

Hi Leo,

On Fri, Jun 17, 2022 at 12:45 AM Leo Yan <leo.yan@...aro.org> wrote:
>
> On Fri, Jun 17, 2022 at 03:38:40PM +0800, Leo Yan wrote:
> > Hi Namhyung,
> >
> > On Thu, Jun 16, 2022 at 04:05:46PM -0700, Namhyung Kim wrote:
> >
> > [...]
> >
> > > +arm_spe_system_wide_test() {
> > > +   echo "Recording trace with system-wide mode $perfdata"
> > > +   perf record -o ${perfdata} -e arm_spe// -a \
> > > +           -- dd if=/dev/zero of=/dev/null count=100000 > /dev/null 2>&1
> > > +
> > > +   if [ $? != 0 ]; then
> > > +           arm_spe_report "SPE system-wide testing" 2
> > > +           return
> > > +   fi
> >
> > I am awared the root permission issue after I saw German's suggestion.
> >
> > If the snapshot test is passed, no matter the system wide test is passed
> > or not, we will always return 0 for 'passed' result.  But we might miss
> > to capture the system-wide testing failure.
> >
> > How about use 'dummy' event to verіfy the root permission?
> > (actually I referred to intel-pt test):
> >
> >         perf record -o ${perfdata} -B -N --no-bpf-event -e dummy:u -a true 2>&1 >/dev/null
> >         if [ $? != 0 ]; then
> >               arm_spe_report "SPE system-wide testing" 2
> >               return
> >         fi
> >
> >         perf record -o ${perfdata} -e arm_spe// -a \
> >                   -- dd if=/dev/zero of=/dev/null count=100000 > /dev/null 2>&1

Ok, will add the change.

Thanks,
Namhyung