linux-kernel - Re: [PATCH] crypto: ccp - During shutdown, check SEV data pointer before using

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YrWAhEnXg5rpamhR@gondor.apana.org.au>
Date:   Fri, 24 Jun 2022 17:14:44 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Tom Lendacky <thomas.lendacky@....com>
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        John Allen <john.allen@....com>,
        Ashish Kalra <ashish.kalra@....com>,
        Michael Roth <michael.roth@....com>
Subject: Re: [PATCH] crypto: ccp - During shutdown, check SEV data pointer
 before using

On Thu, Jun 16, 2022 at 10:26:18AM -0500, Tom Lendacky wrote:
> On shutdown, each CCP device instance performs shutdown processing.
> However, __sev_platform_shutdown_locked() uses the controlling psp
> structure to obtain the pointer to the sev_device structure. However,
> during driver initialization, it is possible that an error can be received
> from the firmware that results in the sev_data pointer being cleared from
> the controlling psp structure. The __sev_platform_shutdown_locked()
> function does not check for this situation and will segfault.
> 
> While not common, this scenario should be accounted for. Add a check for a
> NULL sev_device structure before attempting to use it.
> 
> Fixes: 5441a07a127f ("crypto: ccp - shutdown SEV firmware on kexec")
> Signed-off-by: Tom Lendacky <thomas.lendacky@....com>
> ---
>  drivers/crypto/ccp/sev-dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt