linux-kernel - Re: [PATCH 05/10] dt-bindings: iio: adc: mcp3911: add microchip,data-ready-hiz entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Jun 2022 14:10:29 +0200
From:   Marcus Folkesson <marcus.folkesson@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Kent Gustavsson <kent@...oris.se>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/10] dt-bindings: iio: adc: mcp3911: add
 microchip,data-ready-hiz entry

On Fri, Jun 24, 2022 at 11:54:58AM +0200, Krzysztof Kozlowski wrote:
> > +  microchip,data-ready-hiz:
> > +    description:
> > +      Data Ready Pin Inactive State Control bit
> 
> "Bit" of what? Do not describe the programming model but the actual feature.
> 

You are right. I will remove "bit".

> > +      true = The DR pin state is high-impedance when data are NOT ready
> > +      false = The DR pin state is a logic high when data are NOT ready
> > +    type: boolean
> > +    default: false
> 
> You do not need default for bools.

OK
> 
> > +
> >    microchip,device-addr:
> >      description: Device address when multiple MCP3911 chips are present on the same SPI bus.
> >      $ref: /schemas/types.yaml#/definitions/uint32
> 
> 
> Best regards,
> Krzysztof

Thanks,
Marcus Folkesson



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)