linux-kernel - Re: [PATCH v2 01/12] regmap-irq: Convert bool bitfields to unsigned int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YrW0dlXWhOo+a0sf@sirena.org.uk>
Date:   Fri, 24 Jun 2022 13:56:22 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Aidan MacDonald <aidanmacdonald.0x0@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Matti Vaittinen <mazziesaccount@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 01/12] regmap-irq: Convert bool bitfields to unsigned
 int

On Fri, Jun 24, 2022 at 05:46:10AM -0700, Joe Perches wrote:
> On Fri, 2022-06-24 at 13:11 +0100, Mark Brown wrote:
> > On Thu, Jun 23, 2022 at 11:26:10PM +0200, Andy Shevchenko wrote:

> > > There is no point to convert the fields you are about to remove.
> > 
> > > So, either don't touch them or make this patch closer to the end of the series.

> > It costs us nothing to convert them, this isn't a difficult or hard to
> > understand refactoring - the patch is fine the way it is.

> Modulo the defects that might be introduced if an overflow occurs.

This won't be an issue if the fields are removed which was what Andy was
complaining about.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)