linux-kernel - Re: [PATCH -next] drm: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YrXXnfFLrYFXInvJ@aptenodytes>
Date:   Fri, 24 Jun 2022 17:26:21 +0200
From:   Paul Kocialkowski <paul.kocialkowski@...tlin.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     airlied@...ux.ie, daniel@...ll.ch, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] drm: Remove unnecessary print function dev_err()

Hi,

On Fri 24 Jun 22, 17:00, Paul Kocialkowski wrote:
> Hi Yang,
> 
> On Mon 13 Jun 22, 09:26, Yang Li wrote:
> > The print function dev_err() is redundant because platform_get_irq()
> > already prints an error.
> > 
> > Eliminate the follow coccicheck warning:
> > ./drivers/gpu/drm/logicvc/logicvc_drm.c:352:2-9: line 352 is redundant
> > because platform_get_irq() already prints an error
> > 
> > Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> 
> Thanks for the patch!
> 
> Acked-by: Paul Kocialkowski <paul.kocialkowski@...tlin.com>

Pushed to drm-misc-next, thanks!

Paul

> > ---
> >  drivers/gpu/drm/logicvc/logicvc_drm.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicvc/logicvc_drm.c
> > index df1805cf0f95..437b3011ae1e 100644
> > --- a/drivers/gpu/drm/logicvc/logicvc_drm.c
> > +++ b/drivers/gpu/drm/logicvc/logicvc_drm.c
> > @@ -349,7 +349,6 @@ static int logicvc_drm_probe(struct platform_device *pdev)
> >  
> >  	irq = platform_get_irq(pdev, 0);
> >  	if (irq < 0) {
> > -		dev_err(dev, "Failed to get IRQ\n");
> >  		ret = -ENODEV;
> >  		goto error_reserved_mem;
> >  	}
> > -- 
> > 2.20.1.7.g153144c
> > 
> 
> -- 
> Paul Kocialkowski, Bootlin
> Embedded Linux and kernel engineering
> https://bootlin.com



-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Download attachment "signature.asc" of type "application/pgp-signature" (485 bytes)