linux-kernel - Re: [PATCH v3 19/40] arm64: dts: tegra: align gpio-key node names with dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dcd4be85-21ab-beb9-e6dc-bd7f570459fd@linaro.org>
Date:   Fri, 24 Jun 2022 18:09:44 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     arm@...nel.org, soc@...nel.org, Arnd Bergmann <arnd@...db.de>,
        Olof Johansson <olof@...om.net>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jonathan Hunter <jonathanh@...dia.com>,
        devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 19/40] arm64: dts: tegra: align gpio-key node names
 with dtschema

On 24/06/2022 18:08, Thierry Reding wrote:
> On Wed, Jun 15, 2022 at 05:53:12PM -0700, Krzysztof Kozlowski wrote:
> [...]
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
>> index f16acb4cabaa..62d58221ad3c 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
>> +++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
>> @@ -1030,7 +1030,7 @@ clk32k_in: clock-32k {
>>  	gpio-keys {
>>  		compatible = "gpio-keys";
>>  
>> -		lid {
>> +		switch-lid {
>>  			label = "Lid";
>>  			gpios = <&gpio TEGRA_GPIO(R, 4) GPIO_ACTIVE_LOW>;
>>  			linux,input-type = <5>;
>> @@ -1039,7 +1039,7 @@ lid {
>>  			wakeup-source;
>>  		};
>>  
>> -		power {
>> +		switch-power {
> 
> This one is actually a key.
> 
> [...]
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
>> index a263d51882ee..8494c7b2961b 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
>> +++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> [...]
>> @@ -1772,7 +1772,7 @@ lid {
>>  			wakeup-source;
>>  		};
>>  
>> -		tablet_mode {
>> +		key-tablet-mode {
>>  			label = "Tablet Mode";
>>  			gpios = <&gpio TEGRA_GPIO(Z, 2) GPIO_ACTIVE_HIGH>;
>>  			linux,input-type = <EV_SW>;
> 
> And this one more like a switch since it's triggered by a magnet, as far
> as I understand.
> 
> No need to resend, I can fix these up when I apply. Just let me know if
> you have any objections to me making those changes.

Sounds good, thanks for catching these.


Best regards,
Krzysztof