linux-kernel - Re: [PATCH] lib/radix-tree: Remove unuse argument of insert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YrXspV63H5Wuyd/j@casper.infradead.org>
Date:   Fri, 24 Jun 2022 17:56:05 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     wuchi <wuchi.zero@...il.com>
Cc:     rdunlap@...radead.org, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/radix-tree: Remove unuse argument of insert_entries

On Fri, Jun 24, 2022 at 09:15:23PM +0800, wuchi wrote:
> Function insert_entries doesn't use the 'bool replace' argument,
> and the function is only used locally, remove the argument.

Thanks.  For these kinds of patches, I like the changelog to contain the
historical context for when the code changed to make this argument unused.
Can you add that?

> Signed-off-by: wuchi <wuchi.zero@...il.com>
> ---
>  lib/radix-tree.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/radix-tree.c b/lib/radix-tree.c
> index b3afafe46fff..3c78e1e8b2ad 100644
> --- a/lib/radix-tree.c
> +++ b/lib/radix-tree.c
> @@ -677,7 +677,7 @@ static void radix_tree_free_nodes(struct radix_tree_node *node)
>  }
>  
>  static inline int insert_entries(struct radix_tree_node *node,
> -		void __rcu **slot, void *item, bool replace)
> +		void __rcu **slot, void *item)
>  {
>  	if (*slot)
>  		return -EEXIST;
> @@ -711,7 +711,7 @@ int radix_tree_insert(struct radix_tree_root *root, unsigned long index,
>  	if (error)
>  		return error;
>  
> -	error = insert_entries(node, slot, item, false);
> +	error = insert_entries(node, slot, item);
>  	if (error < 0)
>  		return error;
>  
> -- 
> 2.20.1
>