linux-kernel - Re: [PATCH v3 2/2] PCI: qcom: move register accesses to .post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220624170641.GA1541953@bhelgaas>
Date:   Fri, 24 Jun 2022 12:06:41 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Robert Marko <robimarko@...il.com>
Cc:     Stanimir Varbanov <svarbanov@...sol.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        lpieralisi@...nel.org, Rob Herring <robh@...nel.org>, kw@...ux.com,
        Bjorn Helgaas <bhelgaas@...gle.com>, p.zabel@...gutronix.de,
        jingoohan1@...il.com, linux-pci@...r.kernel.org,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        johan+linaro@...nel.org,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Subject: Re: [PATCH v3 2/2] PCI: qcom: move register accesses to .post_init

On Fri, Jun 24, 2022 at 12:46:55PM +0200, Robert Marko wrote:
> On Fri, 24 Jun 2022 at 12:36, Robert Marko <robimarko@...il.com> wrote:
> > On Thu, 23 Jun 2022 at 23:55, Bjorn Helgaas <helgaas@...nel.org> wrote:
> > > On Thu, Jun 23, 2022 at 05:50:04PM +0200, Robert Marko wrote:
> > > > Move register accesses from .init to .post_init callbacks to maintain
> > > > consinstency for all IP since IPQ8074 specifically requires PHY-s to be
> > > > powered on before register access and its accesses have been moved to
> > > > .post_init.
> > >
> > > This doesn't do the corresponding move for qcom_pcie_init_2_7_0().  Is
> > > that intentional or an oversight?
> >
> > Hi,
> >
> > It was an oversight on my part, will fixup it now, sorry for the mistake.
> >
> > Regards,
> > Robert
> 
> Bjorn,
> 
> I updated the title and description based on your fixups in your branch,
> hope that is ok.

It's great, thanks for noticing and paying attention to the little
details!

Bjorn