[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <eb00b6c3-ae5e-9858-ab5f-fd78229ff436@linaro.org>
Date: Fri, 24 Jun 2022 19:17:53 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Serge Semin <Sergey.Semin@...kalelectronics.ru>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Felipe Balbi <balbi@...nel.org>,
Michael Ellerman <mpe@...erman.id.au>,
Vladimir Zapolskiy <vz@...ia.com>,
Alexey Brodkin <abrodkin@...opsys.com>,
Vineet Gupta <vgupta@...opsys.com>,
Rob Herring <robh+dt@...nel.org>,
Rob Herring <robh@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Krzysztof Kozlowski <krzk@...nel.org>,
linux-usb@...r.kernel.org,
Khuong Dinh <khuong@...amperecomputing.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: Serge Semin <fancer.lancer@...il.com>,
Patrice Chotard <patrice.chotard@...com>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Paul Mackerras <paulus@...ba.org>,
linux-arm-msm@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linuxppc-dev@...ts.ozlabs.org, linux-snps-arc@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND v9 5/5] arm64: dts: apm: Harmonize DWC USB3 DT
nodes name
On 24/06/2022 16:16, Serge Semin wrote:
> In accordance with the DWC USB3 bindings the corresponding node
> name is suppose to comply with the Generic USB HCD DT schema, which
> requires the USB nodes to have the name acceptable by the regexp:
> "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly
> named despite of the warning comment about possible backward
> compatibility issues.
Sometimes node name is exposed to user-space which depends on it. How
did you check there is no issue here?
>
> Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru>
> Acked-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
> arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 4 ++--
> arch/arm64/boot/dts/apm/apm-storm.dtsi | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> index a83c82c50e29..832dd85b00bd 100644
> --- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> +++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> @@ -597,8 +597,8 @@ serial0: serial@...00000 {
> interrupts = <0x0 0x4c 0x4>;
> };
>
> - /* Do not change dwusb name, coded for backward compatibility */
> - usb0: dwusb@...00000 {
> + /* Node-name might need to be coded as dwusb for backward compatibility */
> + usb0: usb@...00000 {
> status = "disabled";
> compatible = "snps,dwc3";
> reg = <0x0 0x19000000 0x0 0x100000>;
> diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
> index 0f37e77f5459..1520a945b7f9 100644
> --- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
> +++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
> @@ -923,8 +923,8 @@ sata3: sata@...00000 {
> phy-names = "sata-phy";
> };
>
> - /* Do not change dwusb name, coded for backward compatibility */
> - usb0: dwusb@...00000 {
> + /* Node-name might need to be coded as dwusb for backward compatibility */
> + usb0: usb@...00000 {
> status = "disabled";
> compatible = "snps,dwc3";
> reg = <0x0 0x19000000 0x0 0x100000>;
> @@ -933,7 +933,7 @@ usb0: dwusb@...00000 {
> dr_mode = "host";
> };
>
> - usb1: dwusb@...00000 {
> + usb1: usb@...00000 {
> status = "disabled";
> compatible = "snps,dwc3";
> reg = <0x0 0x19800000 0x0 0x100000>;
Best regards,
Krzysztof
Powered by blists - more mailing lists