linux-kernel - [bvanassche:block-bitwise-opf 54/57] kernel/power/swap.c:279:45: error: 'op' undeclared; did you mean 'opf'?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 25 Jun 2022 11:22:39 +0800
From:   kernel test robot <lkp@...el.com>
To:     Bart Van Assche <bvanassche@....org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [bvanassche:block-bitwise-opf 54/57] kernel/power/swap.c:279:45:
 error: 'op' undeclared; did you mean 'opf'?

tree:   https://github.com/bvanassche/linux block-bitwise-opf
head:   1dcb3ec8225b66570ecb07a784df045e3944e6ed
commit: 1ee1fd29d2216a7ce21a47ebd4e2fa1b8480f041 [54/57] PM: Use the enum req_op and blk_opf_t types
config: i386-defconfig
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/bvanassche/linux/commit/1ee1fd29d2216a7ce21a47ebd4e2fa1b8480f041
        git remote add bvanassche https://github.com/bvanassche/linux
        git fetch --no-tags bvanassche block-bitwise-opf
        git checkout 1ee1fd29d2216a7ce21a47ebd4e2fa1b8480f041
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   kernel/power/swap.c: In function 'hib_submit_io':
>> kernel/power/swap.c:279:45: error: 'op' undeclared (first use in this function); did you mean 'opf'?
     279 |         bio = bio_alloc(hib_resume_bdev, 1, op | op_flags,
         |                                             ^~
         |                                             opf
   kernel/power/swap.c:279:45: note: each undeclared identifier is reported only once for each function it appears in
>> kernel/power/swap.c:279:50: error: 'op_flags' undeclared (first use in this function); did you mean 'bip_flags'?
     279 |         bio = bio_alloc(hib_resume_bdev, 1, op | op_flags,
         |                                                  ^~~~~~~~
         |                                                  bip_flags


vim +279 kernel/power/swap.c

343df3c79c62b6 Christoph Hellwig 2015-05-19  271  
1ee1fd29d2216a Bart Van Assche   2022-06-17  272  static int hib_submit_io(blk_opf_t opf, pgoff_t page_off, void *addr,
343df3c79c62b6 Christoph Hellwig 2015-05-19  273  			 struct hib_bio_batch *hb)
343df3c79c62b6 Christoph Hellwig 2015-05-19  274  {
343df3c79c62b6 Christoph Hellwig 2015-05-19  275  	struct page *page = virt_to_page(addr);
343df3c79c62b6 Christoph Hellwig 2015-05-19  276  	struct bio *bio;
343df3c79c62b6 Christoph Hellwig 2015-05-19  277  	int error = 0;
343df3c79c62b6 Christoph Hellwig 2015-05-19  278  
07888c665b405b Christoph Hellwig 2022-01-24 @279  	bio = bio_alloc(hib_resume_bdev, 1, op | op_flags,
07888c665b405b Christoph Hellwig 2022-01-24  280  			GFP_NOIO | __GFP_HIGH);
343df3c79c62b6 Christoph Hellwig 2015-05-19  281  	bio->bi_iter.bi_sector = page_off * (PAGE_SIZE >> 9);
343df3c79c62b6 Christoph Hellwig 2015-05-19  282  
343df3c79c62b6 Christoph Hellwig 2015-05-19  283  	if (bio_add_page(bio, page, PAGE_SIZE, 0) < PAGE_SIZE) {
64ec72a1ece37d Joe Perches       2017-09-27  284  		pr_err("Adding page to bio failed at %llu\n",
343df3c79c62b6 Christoph Hellwig 2015-05-19  285  		       (unsigned long long)bio->bi_iter.bi_sector);
343df3c79c62b6 Christoph Hellwig 2015-05-19  286  		bio_put(bio);
343df3c79c62b6 Christoph Hellwig 2015-05-19  287  		return -EFAULT;
343df3c79c62b6 Christoph Hellwig 2015-05-19  288  	}
343df3c79c62b6 Christoph Hellwig 2015-05-19  289  
343df3c79c62b6 Christoph Hellwig 2015-05-19  290  	if (hb) {
343df3c79c62b6 Christoph Hellwig 2015-05-19  291  		bio->bi_end_io = hib_end_io;
343df3c79c62b6 Christoph Hellwig 2015-05-19  292  		bio->bi_private = hb;
343df3c79c62b6 Christoph Hellwig 2015-05-19  293  		atomic_inc(&hb->count);
4e49ea4a3d2763 Mike Christie     2016-06-05  294  		submit_bio(bio);
343df3c79c62b6 Christoph Hellwig 2015-05-19  295  	} else {
4e49ea4a3d2763 Mike Christie     2016-06-05  296  		error = submit_bio_wait(bio);
343df3c79c62b6 Christoph Hellwig 2015-05-19  297  		bio_put(bio);
343df3c79c62b6 Christoph Hellwig 2015-05-19  298  	}
343df3c79c62b6 Christoph Hellwig 2015-05-19  299  
343df3c79c62b6 Christoph Hellwig 2015-05-19  300  	return error;
343df3c79c62b6 Christoph Hellwig 2015-05-19  301  }
343df3c79c62b6 Christoph Hellwig 2015-05-19  302  

:::::: The code at line 279 was first introduced by commit
:::::: 07888c665b405b1cd3577ddebfeb74f4717a84c4 block: pass a block_device and opf to bio_alloc

:::::: TO: Christoph Hellwig <hch@....de>
:::::: CC: Jens Axboe <axboe@...nel.dk>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp