[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <06e1a03f-8529-b1ec-bdaf-79e67185043d@huawei.com>
Date: Sat, 25 Jun 2022 11:33:13 +0800
From: Miaohe Lin <linmiaohe@...wei.com>
To: Zach O'Keefe <zokeefe@...gle.com>
CC: <akpm@...ux-foundation.org>, <shy828301@...il.com>,
<willy@...radead.org>, <linux-mm@...ck.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 03/16] mm/huge_memory: fix comment of
__pud_trans_huge_lock
On 2022/6/25 2:47, Zach O'Keefe wrote:
> On 23 Jun 01:06, Miaohe Lin wrote:
>> __pud_trans_huge_lock returns page table lock pointer if a given pud maps
>> a thp instead of 'true' since introduced. Fix corresponding comments.
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
>> ---
>> mm/huge_memory.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
>> index 83fb6c3442ff..a26580da8011 100644
>> --- a/mm/huge_memory.c
>> +++ b/mm/huge_memory.c
>> @@ -1903,10 +1903,10 @@ spinlock_t *__pmd_trans_huge_lock(pmd_t *pmd, struct vm_area_struct *vma)
>> }
>>
>> /*
>> - * Returns true if a given pud maps a thp, false otherwise.
>> + * Returns page table lock pointer if a given pud maps a thp, NULL otherwise.
>> *
>> - * Note that if it returns true, this routine returns without unlocking page
>> - * table lock. So callers must unlock it.
>> + * Note that if it returns page table lock pointe, this routine returns without
>
> s/pointe/pointer
Thanks for catching this.
>
>> + * unlocking page table lock. So callers must unlock it.
>> */
>> spinlock_t *__pud_trans_huge_lock(pud_t *pud, struct vm_area_struct *vma)
>> {
>> --
>> 2.23.0
>>
> .
>
Powered by blists - more mailing lists