linux-kernel - Re: [PATCH 1/6] ksmbd: use vfs_llseek instead of dereferencing NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd_Lc9+HUuVD-UDvk4ff0KAtMLqEWBs2syFzUszpSDb_Sw@mail.gmail.com>
Date:   Sat, 25 Jun 2022 13:10:21 +0900
From:   Namjae Jeon <linkinjeon@...nel.org>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk,
        Jens Axboe <axboe@...nel.dk>, linux-fsdevel@...r.kernel.org,
        stable@...r.kernel.org, linux-cifs@...r.kernel.org,
        Namjae Jeon <namjae.jeon@...sung.com>,
        Steve French <stfrench@...rosoft.com>,
        Ronnie Sahlberg <lsahlber@...hat.com>,
        Hyunchul Lee <hyc.lee@...il.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH 1/6] ksmbd: use vfs_llseek instead of dereferencing NULL

2022-06-25 1:56 GMT+09:00, Jason A. Donenfeld <Jason@...c4.com>:
> By not checking whether llseek is NULL, this might jump to NULL. Also,
> it doesn't check FMODE_LSEEK. Fix this by using vfs_llseek(), which
> always does the right thing.
>
> Fixes: f44158485826 ("cifsd: add file operations")
> Cc: stable@...r.kernel.org
> Cc: linux-cifs@...r.kernel.org
> Cc: Namjae Jeon <namjae.jeon@...sung.com>
> Cc: Steve French <stfrench@...rosoft.com>
> Cc: Ronnie Sahlberg <lsahlber@...hat.com>
> Cc: Hyunchul Lee <hyc.lee@...il.com>
> Cc: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>

Reviewed-by: Namjae Jeon <linkinjeon@...nel.org>

Thanks!