linux-kernel - Re: [PATCH] page-flags.h: Fix a missing header include of static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 25 Jun 2022 16:49:32 +0800
From:   Muchun Song <songmuchun@...edance.com>
To:     Feiyang Chen <chris.chenfeiyang@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Matthew Wilcox <willy@...radead.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Feiyang Chen <chenfeiyang@...ngson.cn>, chenhuacai@...nel.org,
        loongarch@...ts.linux.dev, LKML <linux-kernel@...r.kernel.org>,
        linux- stable <stable@...r.kernel.org>
Subject: Re: [PATCH] page-flags.h: Fix a missing header include of static_keys.h

On Sat, Jun 25, 2022 at 4:04 PM Feiyang Chen
<chris.chenfeiyang@...il.com> wrote:
>
> The page-flags.h header relies on static keys since commit
> a6b40850c442bf ("mm: hugetlb: replace hugetlb_free_vmemmap_enabled
> with a static_key"), so make sure to include the header to avoid
> compilation errors.
>
> Fixes: a6b40850c442bf ("mm: hugetlb: replace hugetlb_free_vmemmap_enabled with a static_key")
> Cc: stable@...r.kernel.org
> Signed-off-by: Feiyang Chen <chenfeiyang@...ngson.cn>
> ---
>  include/linux/page-flags.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index e66f7aa3191d..147b336c7a35 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -11,6 +11,7 @@
>  #include <linux/mmdebug.h>
>  #ifndef __GENERATING_BOUNDS_H
>  #include <linux/mm_types.h>
> +#include <linux/static_key.h>

I did not include this. The change makes sense to me. But I am
curious what configs cause the compiling error. Would you mind
sharing the config with us?

Thanks.

>  #include <generated/bounds.h>
>  #endif /* !__GENERATING_BOUNDS_H */
>
> --
> 2.27.0
>