linux-kernel - Re: [PATCH v12 4/5] arm64: dts: qcom: sc7180: Add pazquel dts files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 24 Jun 2022 17:19:05 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     "Joseph S. Barrera III" <joebar@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Alexandru M Stan <amstan@...omium.org>,
        Douglas Anderson <dianders@...omium.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v12 4/5] arm64: dts: qcom: sc7180: Add pazquel dts files

Quoting Joseph S. Barrera III (2022-06-24 17:10:08)
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi
> index f869e6a343c1..6938e74792a7 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi
> @@ -5,6 +5,7 @@
>   * Copyright 2021 Google LLC.
>   */
>
> +#include "sc7180-trogdor.dtsi"

I don't think we need to include this at all. Instead, wherever this
dtsi file (sc7180-trogdor-ti-sn65dsi86.dtsi) is included, we should have
already included sc7180-trogdor.dtsi

>  #include <dt-bindings/gpio/gpio.h>
>
>  &dsi0_out {
> --
> 2.31.0
>